From: Eric Sunshine <sunshine@sunshineco.com>
To: Ben Wijen <ben@wijen.net>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] git clone: check for non-empty directory
Date: Thu, 2 Jul 2020 01:32:15 -0400 [thread overview]
Message-ID: <CAPig+cQwJKSVMP8G7E62bESERYsAFTUN2PBX32YWMhECjU=qTQ@mail.gmail.com> (raw)
In-Reply-To: <CAPig+cT+cXuM3Asu6+Z25pGV2uRm6K1iAeYVhic9kqk1mS84-g@mail.gmail.com>
On Wed, Jul 1, 2020 at 12:00 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
> One other observation: To preserve bisectability (git-bisect) of
> git.git itself, we want to ensure that the entire test suite still
> passes at each point in a patch series. Making this change to the test
> in its own patch introduces a failure into the test suite, which is
> undesirable. One way to address this shortcoming would be to
> temporarily change this test from 'test_must_succeed' to
> 'test_must_fail', and then flip it back to 'test_must_succeed' in
> patch 2/2. [...]
And another correction: I meant 'test_expect_success' and
'test_expect_failure', respectively.
next prev parent reply other threads:[~2020-07-02 5:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 9:36 [PATCH 0/2] git clone with --separate-git-dir destroys existing directory content Ben Wijen
2020-07-01 9:36 ` [PATCH 1/2] git clone: check for non-empty directory Ben Wijen
2020-07-01 16:00 ` Eric Sunshine
2020-07-01 17:40 ` Eric Sunshine
2020-07-02 5:32 ` Eric Sunshine [this message]
2020-07-01 9:36 ` [PATCH 2/2] git clone: don't clone into " Ben Wijen
2020-07-01 16:10 ` Eric Sunshine
2020-07-02 7:50 ` Ben
2020-07-01 15:39 ` [PATCH 0/2] git clone with --separate-git-dir destroys existing directory content Eric Sunshine
2020-07-02 8:13 ` [PATCH v2 0/1] git clone: don't clone into non-empty directory Ben Wijen
2020-07-02 8:13 ` [PATCH v2 1/1] " Ben Wijen
2020-07-06 22:40 ` Junio C Hamano
2020-07-10 8:47 ` [PATCH v3 0/1] " Ben Wijen
2020-07-10 8:47 ` [PATCH v3 1/1] " Ben Wijen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cQwJKSVMP8G7E62bESERYsAFTUN2PBX32YWMhECjU=qTQ@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=ben@wijen.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).