From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>, Kevin Brodsky <corax26@gmail.com>
Subject: Re: [PATCH] git-format-patch.txt: don't show -s as shorthand for multiple options
Date: Mon, 4 Apr 2016 18:38:47 -0400 [thread overview]
Message-ID: <CAPig+cR1mmx+2D7U8ejx8HTWbFtxbmi-85D0hgm9J48bkai6CA@mail.gmail.com> (raw)
In-Reply-To: <xmqqr3el3zox.fsf@gitster.mtv.corp.google.com>
On Mon, Apr 4, 2016 at 4:07 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Eric Sunshine <sunshine@sunshineco.com> writes:
>>> Given that the ifndef/endif block immediately before this part is
>>> also about excluding -p/-u/--patch when formatting the documentation
>>> for format-patch, perhaps the attached may be a smaller equivalent?
>>
>> Perhaps. I kept self-contained to make it easier to add new options
>> between the two if need be, but I don't feel strongly about it.
>
> I don't either, but the reason why I thought it would make sense to
> have them in the same block is because hiding --no-patch and --patch
> are about the same theme: format-patch is about presenting the diff,
> and neither disabling diff output nor explicitly asking for diff
> output makes sense.
That's reasonable. Should I re-roll, or would you like to amend it locally?
next prev parent reply other threads:[~2016-04-04 22:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-27 21:26 [PATCH] git-format-patch.txt: don't show -s as shorthand for multiple options Eric Sunshine
2016-04-04 17:34 ` Eric Sunshine
2016-04-04 19:32 ` Junio C Hamano
2016-04-04 19:48 ` Eric Sunshine
2016-04-04 20:07 ` Junio C Hamano
2016-04-04 22:38 ` Eric Sunshine [this message]
2016-04-04 22:44 ` Eric Sunshine
2016-04-08 18:22 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cR1mmx+2D7U8ejx8HTWbFtxbmi-85D0hgm9J48bkai6CA@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=corax26@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).