From: Eric Sunshine <sunshine@sunshineco.com>
To: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, Git <git@vger.kernel.org>
Subject: Re: [PATCH] submodule-config: use hashmap_iter_init()
Date: Tue, 15 Mar 2016 14:58:05 -0400 [thread overview]
Message-ID: <CAPig+cR6Cy2MHvoTxNa89gZx9qJZW1Rv93N+wcwK2JRGkUBzRw@mail.gmail.com> (raw)
In-Reply-To: <1458066330-5107-1-git-send-email-kuleshovmail@gmail.com>
On Tue, Mar 15, 2016 at 2:25 PM, Alexander Kuleshov
<kuleshovmail@gmail.com> wrote:
> submodule-config: use hashmap_iter_init()
Did you mean s/init/first/ ?
> from the <hashmap.h> for simplification.
Sentence fragment...
Missing sign-off.
> ---
> diff --git a/submodule-config.c b/submodule-config.c
> index b82d1fb..8ac5031 100644
> --- a/submodule-config.c
> +++ b/submodule-config.c
> @@ -405,8 +405,7 @@ static const struct submodule *config_from(struct submodule_cache *cache,
> struct hashmap_iter iter;
> struct submodule_entry *entry;
>
> - hashmap_iter_init(&cache->for_name, &iter);
> - entry = hashmap_iter_next(&iter);
> + entry = hashmap_iter_first(&cache->for_name, &iter);
> if (!entry)
> return NULL;
> return entry->config;
> --
next prev parent reply other threads:[~2016-03-15 18:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 18:25 [PATCH] submodule-config: use hashmap_iter_init() Alexander Kuleshov
2016-03-15 18:58 ` Eric Sunshine [this message]
2016-03-15 19:08 ` Stefan Beller
2016-03-15 19:10 ` Alexander Kuleshov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cR6Cy2MHvoTxNa89gZx9qJZW1Rv93N+wcwK2JRGkUBzRw@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kuleshovmail@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).