From: Eric Sunshine <sunshine@sunshineco.com>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: Git List <git@vger.kernel.org>,
Christian Couder <christian.couder@gmail.com>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v14 05/13] ref-filter: add option to filter out tags, branches and remotes
Date: Sun, 30 Aug 2015 03:16:06 -0400 [thread overview]
Message-ID: <CAPig+cRK9Ljj_qO36JhYtt+2aGC0NfhC0AeuT65B_mYj25+nnw@mail.gmail.com> (raw)
In-Reply-To: <CAOLa=ZSn6z03+jU1Ytn6nL0f0hQ36YAxG4629E1jTpyiaO7BZQ@mail.gmail.com>
On Sun, Aug 30, 2015 at 2:51 AM, Karthik Nayak <karthik.188@gmail.com> wrote:
> On Sun, Aug 30, 2015 at 9:00 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
>> On Sat, Aug 29, 2015 at 10:12 AM, Karthik Nayak <karthik.188@gmail.com> wrote:
>>> +int for_each_fullref_in(const char *prefix, each_ref_fn fn, void *cb_data, unsigned int broken)
>>
>> Booleans such as 'broken' are typically declared 'int' in this
>> codebase, rather than 'unsigned int'.
>
> But doesn't it make more sense to have it as unsigned, since its values are
> either 0 or 1?
In C, zero is false and any other value is true, so from that
viewpoint, the type doesn't matter much. However, beside being raw
instructions for the computer, code should ideally convey its
intention as clearly as possible to other programmers. 'int' for
boolean has been idiomatic since C's inception, thus is a good way to
do so, whereas 'unsigned int' is typically used for magnitude or bit
flags, thus is misleading.
next prev parent reply other threads:[~2015-08-30 7:16 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-29 14:12 [PATCH v14 00/13] Port tag.c to use ref-filter.c Karthik Nayak
2015-08-29 14:12 ` [PATCH v14 01/13] ref-filter: move `struct atom_value` to ref-filter.c Karthik Nayak
2015-08-29 14:12 ` [PATCH v14 02/13] ref-filter: introduce ref_formatting_state and ref_formatting_stack Karthik Nayak
2015-08-29 14:12 ` [PATCH v14 03/13] utf8: add function to align a string into given strbuf Karthik Nayak
2015-08-29 17:10 ` Torsten Bögershausen
2015-08-29 17:33 ` Karthik Nayak
2015-08-29 14:12 ` [PATCH v14 04/13] ref-filter: implement an `align` atom Karthik Nayak
2015-08-30 3:27 ` Eric Sunshine
2015-08-30 13:38 ` Karthik Nayak
2015-08-30 22:10 ` Eric Sunshine
2015-08-31 9:55 ` Karthik Nayak
2015-08-31 17:16 ` Eric Sunshine
2015-08-31 17:28 ` Matthieu Moy
2015-08-31 18:02 ` Eric Sunshine
2015-09-01 13:05 ` Karthik Nayak
2015-09-01 13:11 ` Matthieu Moy
2015-09-01 15:13 ` Karthik Nayak
2015-08-30 14:57 ` Karthik Nayak
2015-08-30 21:59 ` Eric Sunshine
2015-08-31 10:06 ` Karthik Nayak
2015-08-30 17:27 ` Junio C Hamano
2015-08-30 22:56 ` Eric Sunshine
2015-08-31 10:14 ` Karthik Nayak
2015-08-31 10:28 ` Karthik Nayak
2015-08-31 8:30 ` Matthieu Moy
2015-08-31 10:59 ` Karthik Nayak
2015-08-29 14:12 ` [PATCH v14 05/13] ref-filter: add option to filter out tags, branches and remotes Karthik Nayak
2015-08-30 3:30 ` Eric Sunshine
2015-08-30 6:51 ` Karthik Nayak
2015-08-30 7:16 ` Eric Sunshine [this message]
2015-08-29 14:12 ` [PATCH v14 06/13] ref-filter: introduce format_ref_array_item() Karthik Nayak
2015-08-30 3:42 ` Eric Sunshine
2015-08-30 6:39 ` Karthik Nayak
2015-08-30 6:49 ` Karthik Nayak
2015-08-29 14:12 ` [PATCH v14 07/13] ref-filter: add support for %(contents:lines=X) Karthik Nayak
2015-08-30 7:53 ` Eric Sunshine
2015-08-30 17:02 ` Karthik Nayak
2015-08-30 17:09 ` Eric Sunshine
2015-08-30 17:17 ` Karthik Nayak
2015-08-30 22:13 ` Eric Sunshine
2015-08-31 4:43 ` Karthik Nayak
2015-08-29 14:12 ` [PATCH v14 08/13] ref-filter: add support to sort by version Karthik Nayak
2015-08-29 14:12 ` [PATCH v14 09/13] ref-filter: add option to match literal pattern Karthik Nayak
2015-08-29 14:12 ` [PATCH v14 10/13] tag.c: use 'ref-filter' data structures Karthik Nayak
2015-08-29 14:12 ` [PATCH v14 11/13] tag.c: use 'ref-filter' APIs Karthik Nayak
2015-08-29 14:12 ` [PATCH v14 12/13] tag.c: implement '--format' option Karthik Nayak
2015-08-29 14:12 ` [PATCH v14 13/13] tag.c: implement '--merged' and '--no-merged' options Karthik Nayak
2015-08-31 6:50 ` [PATCH v14 00/13] Port tag.c to use ref-filter.c Matthieu Moy
2015-08-31 11:09 ` Karthik Nayak
2015-08-31 7:31 ` Matthieu Moy
2015-08-31 11:36 ` Karthik Nayak
2015-09-01 17:37 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cRK9Ljj_qO36JhYtt+2aGC0NfhC0AeuT65B_mYj25+nnw@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).