Want to start contributing to git through this task: "Use dir-iterator to avoid explicit recursiv

Want to start contributing to git through this task: "Use dir-iterator to avoid explicit recursiv

[vaibhav kurhe]

Hello all,
I am a Git user since last 2 years and now I want to contribute
towards its development.
Yesterday, I had a discussion with Kevin on the IRC channel
#git-devel, where I got this link:-
https://git.github.io/SoC-2018-Microprojects/.
Out of the tasks listed down in above URL, I found this one interesting:-
"Use dir-iterator to avoid explicit recursive directory traversal"
==>
Some places in git use raw API opendir/readdir/closedir to traverse a
directory recursively, which usually involves function recursion. Now
that we have struct dir_iterator (see dir-iterator.h), convert these
to use the dir-iterator to simplify the code. Do only one conversion
per microproject.

I cloned the git repo and browsed through it. I found that in git
clone (buildtin/clone.c), raw directory API readdir() is used
recursively.
So there is a place to change it to use the already available
"dir_iterator" structure.

I just want to know, if anybody is working on this task already.
If not, then I can proceed to work.

Thank you and Regards,
Vaibhav

Re: Want to start contributing to git through this task: "Use dir-iterator to avoid explicit recursiv

[Eric Sunshine]

On Mon, Apr 9, 2018 at 9:51 AM, vaibhav kurhe <vaibhav.kurhe@gmail.com> wrote:
> https://git.github.io/SoC-2018-Microprojects/.
> Out of the tasks listed down in above URL, I found this one interesting:-
> "Use dir-iterator to avoid explicit recursive directory traversal"
> I cloned the git repo and browsed through it. I found that in git
> clone (buildtin/clone.c), raw directory API readdir() is used
> recursively.
> So there is a place to change it to use the already available
> "dir_iterator" structure.
> I just want to know, if anybody is working on this task already.
> If not, then I can proceed to work.

There has been no recent discussion on the mailing list regarding
this, so it is unlikely that anyone else is working on it.

Re: Want to start contributing to git through this task: "Use dir-iterator to avoid explicit recursiv

[Johannes Schindelin]

Hi,

On Mon, 9 Apr 2018, Eric Sunshine wrote:

> On Mon, Apr 9, 2018 at 9:51 AM, vaibhav kurhe <vaibhav.kurhe@gmail.com> wrote:
> > https://git.github.io/SoC-2018-Microprojects/.
> > Out of the tasks listed down in above URL, I found this one interesting:-
> > "Use dir-iterator to avoid explicit recursive directory traversal"
> > I cloned the git repo and browsed through it. I found that in git
> > clone (buildtin/clone.c), raw directory API readdir() is used
> > recursively.
> > So there is a place to change it to use the already available
> > "dir_iterator" structure.
> > I just want to know, if anybody is working on this task already.
> > If not, then I can proceed to work.
> 
> There has been no recent discussion on the mailing list regarding
> this, so it is unlikely that anyone else is working on it.

Indeed.

Please feel free to reach out when you get stuck. If you want to show the
code in progress, may I suggest to publish your topic branch to a public
repository, such as on GitHub?

Ciao,
Johannes