From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Joanna Wang <jojwang@google.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/1] attr: enable attr pathspec magic for git-add and git-stash
Date: Sat, 4 Nov 2023 02:28:25 -0400 [thread overview]
Message-ID: <CAPig+cRR0PfWP0_uoevQnctSosb-k9cp3b08-sQNV5OPuQ2tAg@mail.gmail.com> (raw)
In-Reply-To: <xmqqsf5mgl0r.fsf@gitster.g>
On Sat, Nov 4, 2023 at 1:12 AM Junio C Hamano <gitster@pobox.com> wrote:
> > + if ((magic & pathspec_magic[i].bit) && (pathspec_magic[i].mnemonic != '\0')) {
>
> Overly long, with a stylo.
>
> Here is what I ended up queuing.
>
> + for (int i = 0; i < ARRAY_SIZE(pathspec_magic); i++) {
> + if ((magic & pathspec_magic[i].bit) &&
> + (pathspec_magic[i].mnemonic)) {
Nit: The no-value-added parentheses around
`pathspec_magic[i].mnemonic` can also be dropped.
next prev parent reply other threads:[~2023-11-04 6:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 23:23 [PATCH 1/1] Allow attr magic for git-add, git-stash Joanna Wang
2023-10-06 2:42 ` Junio C Hamano
2023-10-06 17:05 ` Junio C Hamano
2023-10-07 0:28 ` [PATCH 1/1] add: Enable attr pathspec magic for git-add Joanna Wang
2023-10-07 0:50 ` Joanna Wang
2023-10-07 10:10 ` [PATCH " Junio C Hamano
2023-10-11 20:20 ` [PATCH 1/1] add: enable attr pathspec magic Joanna Wang
2023-11-02 1:55 ` [PATCH 1/1] attr: enable attr pathspec magic for git-add and git-stash Joanna Wang
2023-11-02 5:00 ` Junio C Hamano
2023-11-02 17:53 ` Joanna Wang
2023-11-02 21:32 ` Junio C Hamano
2023-11-02 23:45 ` Junio C Hamano
2023-11-03 14:35 ` Joanna Wang
2023-11-03 15:31 ` Ruben Safir
2023-11-03 16:34 ` Joanna Wang
2023-11-04 5:11 ` Junio C Hamano
2023-11-04 6:28 ` Eric Sunshine [this message]
2023-11-04 7:14 ` Junio C Hamano
2023-11-09 23:27 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2023-11-10 2:09 Joanna Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cRR0PfWP0_uoevQnctSosb-k9cp3b08-sQNV5OPuQ2tAg@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jojwang@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).