From: Eric Sunshine <sunshine@sunshineco.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: Mahmoud Al-Qudsi <mqudsi@neosmart.net>,
Git List <git@vger.kernel.org>,
ferdy@gentoo.org, Joachim Schmitz <jojo@schmitz-digital.de>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: Is NO_ICONV misnamed or is it broken?
Date: Sat, 16 Jun 2018 23:41:38 -0400 [thread overview]
Message-ID: <CAPig+cRR8=vbafsjL_pnoq6ssxBkkoVo0OMd_i8P_a8ze7eLHg@mail.gmail.com> (raw)
In-Reply-To: <CAP8UFD2SJF_gbP-mdXoAH0t_OmLjRbPuVK5vZZjgs2N9eJz5KQ@mail.gmail.com>
On Sat, Jun 16, 2018 at 10:57 PM Christian Couder
<christian.couder@gmail.com> wrote:
> On Fri, Jun 15, 2018 at 12:47 AM, Mahmoud Al-Qudsi <mqudsi@neosmart.net> wrote:
> > ~> make NO_ICONV=1
> > # ommitted
> > LINK git-credential-store
> > /usr/bin/ld: cannot find -liconv
> I think 597c9cc540 (Flatten tools/ directory to make build procedure
> simpler., 2005-09-07) which introduces NEEDS_LIBICONV is even older
> than the commit that introduced NO_ICONV (see above), so you might
> want to play with NEEDS_LIBICONV too and see if it works better for
> you.
>
> I CC'ed the people involved in related commits. Maybe they can give
> you a better answer. It might also help if you could tell us on which
> OS/Platform and perhaps for which purpose you want to compile Git.
For completeness, for those reading this thread, a patch fixing this
issue has already been sent[1] to the list.
[1]: https://public-inbox.org/git/20180615022503.34111-1-sunshine@sunshineco.com/
prev parent reply other threads:[~2018-06-17 3:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 22:47 Is NO_ICONV misnamed or is it broken? Mahmoud Al-Qudsi
2018-06-15 2:25 ` [PATCH] Makefile: make NO_ICONV really mean "no iconv" Eric Sunshine
2018-06-15 4:20 ` Jeff King
2018-06-15 6:30 ` Eric Sunshine
2018-06-15 6:39 ` Jeff King
2018-06-15 6:58 ` Simon Ruderich
2018-06-15 7:43 ` Eric Sunshine
2018-06-17 17:32 ` Kaartic Sivaraam
2018-06-17 18:00 ` Eric Sunshine
2018-06-17 18:25 ` Doc/SubmittingPatches: re-phrashing a sentence about alternate solutions (was Re: [PATCH] Makefile: make NO_ICONV really mean "no iconv") Kaartic Sivaraam
2018-06-18 4:20 ` Jeff King
2018-06-18 16:09 ` [PATCH] Makefile: make NO_ICONV really mean "no iconv" Junio C Hamano
2018-06-15 8:15 ` Mahmoud Al-Qudsi
2018-06-17 2:57 ` Is NO_ICONV misnamed or is it broken? Christian Couder
2018-06-17 3:41 ` Eric Sunshine [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cRR8=vbafsjL_pnoq6ssxBkkoVo0OMd_i8P_a8ze7eLHg@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=christian.couder@gmail.com \
--cc=ferdy@gentoo.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jojo@schmitz-digital.de \
--cc=mqudsi@neosmart.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).