git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: Dennis Kaarsemaker <dennis@kaarsemaker.net>
Cc: Git List <git@vger.kernel.org>, ingy@ingy.net
Subject: Re: [PATCH] path_treatment: also ignore $GIT_DIR if it's not .git
Date: Sun, 1 Dec 2013 20:21:53 -0500	[thread overview]
Message-ID: <CAPig+cRVYLsVrmFzfKHE8VdYo90enuOpsir2HT8YueQsWs58ng@mail.gmail.com> (raw)
In-Reply-To: <20131201190447.GA31367@kaarsemaker.net>

On Sun, Dec 1, 2013 at 2:04 PM, Dennis Kaarsemaker
<dennis@kaarsemaker.net> wrote:
> diff --git a/t/t7508-status.sh b/t/t7508-status.sh
> index c987b5e..2bd7ef1 100755
> --- a/t/t7508-status.sh
> +++ b/t/t7508-status.sh
> @@ -198,6 +198,13 @@ test_expect_success 'status -s' '
>
>  '
>
> +test_expect_success 'status -s with non-standard $GIT_DIR' '
> +       mv .git .foo &&
> +       GIT_DIR=.foo git status -s >output &&
> +       test_cmp expect output &&
> +       mv .foo .git

If test_cmp returns a failure status, the following 'mv' command will
never be invoked, thus all subsequent tests in the script will fail
since the .git directory will be missing. Instead, use
test_when_finished to restore .git from .foo.

> +'
> +
>  test_expect_success 'status with gitignore' '
>         {
>                 echo ".gitignore" &&
> --
> 1.8.5-386-gb78cb96

  parent reply	other threads:[~2013-12-02  1:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-01  7:06 GIT_DIR not auto ignored Ingy dot Net
2013-12-01 18:08 ` Dennis Kaarsemaker
2013-12-01 18:30   ` Dennis Kaarsemaker
2013-12-01 19:04     ` [PATCH] path_treatment: also ignore $GIT_DIR if it's not .git Dennis Kaarsemaker
2013-12-01 23:02       ` Duy Nguyen
2013-12-01 23:08         ` Thomas Rast
2013-12-01 23:38           ` Dennis Kaarsemaker
2013-12-02  0:38             ` Duy Nguyen
2013-12-02  8:01               ` Dennis Kaarsemaker
2013-12-02  9:35                 ` Duy Nguyen
2013-12-02 11:40                   ` Dennis Kaarsemaker
2013-12-02 12:01                     ` Duy Nguyen
2013-12-02  1:21       ` Eric Sunshine [this message]
2013-12-03 15:18       ` Karsten Blees
2013-12-03 18:32         ` Junio C Hamano
2013-12-03 19:00           ` Karsten Blees
2013-12-03 19:07           ` Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPig+cRVYLsVrmFzfKHE8VdYo90enuOpsir2HT8YueQsWs58ng@mail.gmail.com \
    --to=sunshine@sunshineco.com \
    --cc=dennis@kaarsemaker.net \
    --cc=git@vger.kernel.org \
    --cc=ingy@ingy.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).