Possible git-gui bug

Possible git-gui bug

[Lauri Reilson]

[-- Attachment #1.1: Type: text/plain, Size: 306 bytes --]

Hello to all!

I have a small issue with git-gui. I added the git-bugreport to the attachement.

Warm regards,

Lauri Reilson * Software Engineer
lauri.reilson@proekspert.ee<mailto:lauri.reilson@proekspert.ee>
PROEKSPERT<https://www.proekspert.ee/> * Sõpruse pst 157, 13417 Tallinn, Estonia, EU


[-- Attachment #1.2: Type: text/html, Size: 3605 bytes --]

[-- Attachment #2: git-bugreport-2025-03-25-1751.txt --]
[-- Type: text/plain, Size: 1584 bytes --]

Thank you for filling out a Git bug report!
Please answer the following questions to help us understand your issue.

What did you do before the bug happened? (Steps to reproduce your issue)
Added files for commiting using git-gui. Provided one line commit message

Whatd did you expect to happen? (Expected behavior)
Expected to commit using git-gui. Commit message was in the format <#task-id message>. I use ";" instead of comment symbol as "#" is used as a means
to track task id.

What happened instead? (Actual behavior)
Git-gui gave error message, that I need to provide commit message. Tried one line, folled the error message (first line, blank line, remaining lines).
Also, when ammending, git-gui messed up the message. Message was in the form of:

#123456 message
<blank line>
- Some small description

And git-gui turned this into:
- Some small description


What's different between what you expected and what actually happened?
Commit message not being what I wrote and not being able to commit.


Anything else you want to add:

Please review the rest of the bug report below.
You can delete any lines you don't wish to share.



[System Info]
git version:
git version 2.49.0.windows.1
cpu: x86_64
sizeof-long: 4
sizeof-size_t: 8
shell-path: D:/git-sdk-64-build-installers/usr/bin/sh
feature: fsmonitor--daemon
libcurl: 8.12.1
OpenSSL: OpenSSL 3.2.4 11 Feb 2025
zlib: 1.3.1
uname: Windows 10.0 26100 
compiler info: gnuc: 14.2, msvc
libc info: no libc information available
$SHELL (typically, interactive shell): C:\Program Files\Git\usr\bin\bash.exe


[Enabled Hooks]

Re: Possible git-gui bug

[Eric Sunshine]

On Wed, Apr 9, 2025 at 7:11 AM Lauri Reilson
<Lauri.Reilson@proekspert.ee> wrote:
> I have a small issue with git-gui. I added the git-bugreport to the attachement.
>
> > Whatd did you expect to happen? (Expected behavior)
> Expected to commit using git-gui. Commit message was in the format <#task-id message>. I use ";" instead of comment symbol as "#" is used as a means to track task id.
>
> > What happened instead? (Actual behavior)
> Git-gui gave error message, that I need to provide commit message. Tried one line, folled the error message (first line, blank line, remaining lines).

This sounds like the problem addressed by [1].

[1]: https://lore.kernel.org/git/20250315140913.577422-1-oswald.buddenhagen@gmx.de/

RE: Possible git-gui bug

[Lauri Reilson]

Hi, Eric!

Sorry for this long response. Thank you for the information. Unfortunately, I don't follow quite well. Is this thing going to be fixed or not?
It has become quite annoying that I cannot make commits with git-gui and there hasn't been any updates.

Best regards,

Lauri Reilson • Software Engineer
lauri.reilson@proekspert.ee
PROEKSPERT • Sõpruse pst 157, 13417 Tallinn, Estonia, EU

-----Original Message-----
From: Eric Sunshine <sunshine@sunshineco.com> 
Sent: Wednesday, April 9, 2025 10:31 PM
To: Lauri Reilson <Lauri.Reilson@proekspert.ee>
Cc: git@vger.kernel.org
Subject: Re: Possible git-gui bug

On Wed, Apr 9, 2025 at 7:11 AM Lauri Reilson <Lauri.Reilson@proekspert.ee> wrote:
> I have a small issue with git-gui. I added the git-bugreport to the attachement.
>
> > Whatd did you expect to happen? (Expected behavior)
> Expected to commit using git-gui. Commit message was in the format <#task-id message>. I use ";" instead of comment symbol as "#" is used as a means to track task id.
>
> > What happened instead? (Actual behavior)
> Git-gui gave error message, that I need to provide commit message. Tried one line, folled the error message (first line, blank line, remaining lines).

This sounds like the problem addressed by [1].

[1]: https://lore.kernel.org/git/20250315140913.577422-1-oswald.buddenhagen@gmx.de/

Re: Possible git-gui bug

[Eric Sunshine]

On Tue, May 13, 2025 at 2:09 PM Lauri Reilson
<Lauri.Reilson@proekspert.ee> wrote:
> > From: Eric Sunshine <sunshine@sunshineco.com>
> > On Wed, Apr 9, 2025 at 7:11 AM Lauri Reilson <Lauri.Reilson@proekspert.ee> wrote:
> > > I have a small issue with git-gui. I added the git-bugreport to the attachement.
> > > Expected to commit using git-gui. Commit message was in the format <#task-id message>. I use ";" instead of comment symbol as "#" is used as a means to track task id.
> > >
> > > > What happened instead? (Actual behavior)
> > > Git-gui gave error message, that I need to provide commit message. Tried one line, folled the error message (first line, blank line, remaining lines).
> >
> > This sounds like the problem addressed by [1].
> >
> > [1]: https://lore.kernel.org/git/20250315140913.577422-1-oswald.buddenhagen@gmx.de/
>
> Sorry for this long response. Thank you for the information.
> Unfortunately, I don't follow quite well. Is this thing going to be
> fixed or not?

It appears that the maintainer of git-gui, Johannes Sixt, applied the
patch mentioned above to his git-gui tree[*] and that Junio already
pulled the fix from Johannes's tree into the Git tree. Although the
fix hasn't yet made it into a Git release, Junio has already promoted
the fix to his "main" branch which means it will likely be part of the
next Git release.

> It has become quite annoying that I cannot make commits with git-gui
> and there hasn't been any updates.

It would be helpful if you could try applying the patch mentioned
above to your local git-gui installation and report back here whether
it indeed fixes the problem you are experiencing. If it does not fix
the problem, then my supposition was wrong about the mentioned patch
being related to the problem you reported. If you're not in a position
to try the patch locally before the next Git release, then perhaps the
best you can do is wait for the next Git release and report back
whether it fixes the problem you're experiencing.

[*] https://github.com/j6t/git-gui/commit/6b43a57dfce1e5acd85f7a8365c080b6fc4f8645

RE: Possible git-gui bug

[Lauri Reilson]

Thank you, Eric!

I'll try it and get back to you. It will take some time. Possibly next week.

Warm regards,

Lauri Reilson • Software Engineer
lauri.reilson@proekspert.ee
PROEKSPERT • Sõpruse pst 157, 13417 Tallinn, Estonia, EU

-----Original Message-----
From: Eric Sunshine <sunshine@sunshineco.com> 
Sent: Tuesday, May 13, 2025 9:32 PM
To: Lauri Reilson <Lauri.Reilson@proekspert.ee>
Cc: git@vger.kernel.org
Subject: Re: Possible git-gui bug

On Tue, May 13, 2025 at 2:09 PM Lauri Reilson <Lauri.Reilson@proekspert.ee> wrote:
> > From: Eric Sunshine <sunshine@sunshineco.com> On Wed, Apr 9, 2025 at 
> > 7:11 AM Lauri Reilson <Lauri.Reilson@proekspert.ee> wrote:
> > > I have a small issue with git-gui. I added the git-bugreport to the attachement.
> > > Expected to commit using git-gui. Commit message was in the format <#task-id message>. I use ";" instead of comment symbol as "#" is used as a means to track task id.
> > >
> > > > What happened instead? (Actual behavior)
> > > Git-gui gave error message, that I need to provide commit message. Tried one line, folled the error message (first line, blank line, remaining lines).
> >
> > This sounds like the problem addressed by [1].
> >
> > [1]: 
> > https://lore.kernel.org/git/20250315140913.577422-1-oswald.buddenhag
> > en@gmx.de/
>
> Sorry for this long response. Thank you for the information.
> Unfortunately, I don't follow quite well. Is this thing going to be 
> fixed or not?

It appears that the maintainer of git-gui, Johannes Sixt, applied the patch mentioned above to his git-gui tree[*] and that Junio already pulled the fix from Johannes's tree into the Git tree. Although the fix hasn't yet made it into a Git release, Junio has already promoted the fix to his "main" branch which means it will likely be part of the next Git release.

> It has become quite annoying that I cannot make commits with git-gui 
> and there hasn't been any updates.

It would be helpful if you could try applying the patch mentioned above to your local git-gui installation and report back here whether it indeed fixes the problem you are experiencing. If it does not fix the problem, then my supposition was wrong about the mentioned patch being related to the problem you reported. If you're not in a position to try the patch locally before the next Git release, then perhaps the best you can do is wait for the next Git release and report back whether it fixes the problem you're experiencing.

[*] https://github.com/j6t/git-gui/commit/6b43a57dfce1e5acd85f7a8365c080b6fc4f8645

RE: Possible git-gui bug

[Lauri Reilson]

Hi, Eric!

I know I promised to check that patch out and get back to you. The first pard I had no time to do. However, I have installed the latest Git version (2.50.0) and my problem is fixed. Thank you for that.

Have an awesome summer!

Lauri Reilson • Software Engineer
lauri.reilson@proekspert.ee
PROEKSPERT • Sõpruse pst 157, 13417 Tallinn, Estonia, EU

-----Original Message-----
From: Lauri Reilson 
Sent: Tuesday, May 13, 2025 9:35 PM
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: git@vger.kernel.org
Subject: RE: Possible git-gui bug

Thank you, Eric!

I'll try it and get back to you. It will take some time. Possibly next week.

Warm regards,

Lauri Reilson • Software Engineer
lauri.reilson@proekspert.ee
PROEKSPERT • Sõpruse pst 157, 13417 Tallinn, Estonia, EU

-----Original Message-----
From: Eric Sunshine <sunshine@sunshineco.com>
Sent: Tuesday, May 13, 2025 9:32 PM
To: Lauri Reilson <Lauri.Reilson@proekspert.ee>
Cc: git@vger.kernel.org
Subject: Re: Possible git-gui bug

On Tue, May 13, 2025 at 2:09 PM Lauri Reilson <Lauri.Reilson@proekspert.ee> wrote:
> > From: Eric Sunshine <sunshine@sunshineco.com> On Wed, Apr 9, 2025 at
> > 7:11 AM Lauri Reilson <Lauri.Reilson@proekspert.ee> wrote:
> > > I have a small issue with git-gui. I added the git-bugreport to the attachement.
> > > Expected to commit using git-gui. Commit message was in the format <#task-id message>. I use ";" instead of comment symbol as "#" is used as a means to track task id.
> > >
> > > > What happened instead? (Actual behavior)
> > > Git-gui gave error message, that I need to provide commit message. Tried one line, folled the error message (first line, blank line, remaining lines).
> >
> > This sounds like the problem addressed by [1].
> >
> > [1]: 
> > https://lore.kernel.org/git/20250315140913.577422-1-oswald.buddenhag
> > en@gmx.de/
>
> Sorry for this long response. Thank you for the information.
> Unfortunately, I don't follow quite well. Is this thing going to be 
> fixed or not?

It appears that the maintainer of git-gui, Johannes Sixt, applied the patch mentioned above to his git-gui tree[*] and that Junio already pulled the fix from Johannes's tree into the Git tree. Although the fix hasn't yet made it into a Git release, Junio has already promoted the fix to his "main" branch which means it will likely be part of the next Git release.

> It has become quite annoying that I cannot make commits with git-gui 
> and there hasn't been any updates.

It would be helpful if you could try applying the patch mentioned above to your local git-gui installation and report back here whether it indeed fixes the problem you are experiencing. If it does not fix the problem, then my supposition was wrong about the mentioned patch being related to the problem you reported. If you're not in a position to try the patch locally before the next Git release, then perhaps the best you can do is wait for the next Git release and report back whether it fixes the problem you're experiencing.

[*] https://github.com/j6t/git-gui/commit/6b43a57dfce1e5acd85f7a8365c080b6fc4f8645

Re: Possible git-gui bug

[Eric Sunshine]

On Wed, Jun 18, 2025 at 5:29 PM Lauri Reilson
<Lauri.Reilson@proekspert.ee> wrote:
> Hi, Eric!
>
> I know I promised to check that patch out and get back to you. The first pard I had no time to do. However, I have installed the latest Git version (2.50.0) and my problem is fixed. Thank you for that.

Thanks for reporting back that Oswald's patch[*] did indeed fix the
problem you reported.

[*]: https://lore.kernel.org/git/20250315140913.577422-1-oswald.buddenhagen@gmx.de/