git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Elijah Newren <newren@gmail.com>,
	blanet <bupt_xingxin@163.com>,
	 Xing Xin <xingxin.xx@bytedance.com>
Subject: Re: [PATCH 1/2] remerge-diff: lazily prpare temporary objdir on demand
Date: Fri, 9 Aug 2024 18:37:52 -0400	[thread overview]
Message-ID: <CAPig+cRYOe7dQg7qwHmHZW9WfVGJ68wWSQHikz-v+_ZhhTkG3Q@mail.gmail.com> (raw)
In-Reply-To: <xmqqv8099vms.fsf@gitster.g>

On Fri, Aug 9, 2024 at 6:31 PM Junio C Hamano <gitster@pobox.com> wrote:
> remerge-diff: lazily prpare temporary objdir on demand

s/prpare/prepare/

> It is error prone for each caller that sets revs.remerge_diff bit
> to be responsible for preparing a temporary object directory and
> rotate it into the list of alternate object stores, making it the
> primary object store.
>
> Instead, remove the code to set up and arrange the temporary object
> directory from the current callers and implement it in the code that
> runs remerge-diff logic.  The code to undo the futzing of the list
> of alternate object store is still spread across the callers, but we
> will deal with it in future steps.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>

      parent reply	other threads:[~2024-08-09 22:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-09 22:30 [PATCH 1/2] remerge-diff: lazily prpare temporary objdir on demand Junio C Hamano
2024-08-09 22:31 ` [PATCH 2/2] remerge-diff: clean up temporary objdir at a central place Junio C Hamano
2024-08-12  5:17   ` Junio C Hamano
2024-08-16  6:19     ` Elijah Newren
2024-09-08 21:16       ` Junio C Hamano
2024-08-09 22:37 ` Eric Sunshine [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPig+cRYOe7dQg7qwHmHZW9WfVGJ68wWSQHikz-v+_ZhhTkG3Q@mail.gmail.com \
    --to=sunshine@sunshineco.com \
    --cc=bupt_xingxin@163.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=newren@gmail.com \
    --cc=xingxin.xx@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).