git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: Jason Karns <karns.17@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: bug in bash completion for git-branch --set-upstream-to on OSX
Date: Sat, 21 Mar 2015 23:24:45 -0400	[thread overview]
Message-ID: <CAPig+cRYQfSNvyCXJc2a4wFAsZ8S4v3zvc5K5-fW+guepMeVPg@mail.gmail.com> (raw)
In-Reply-To: <CAKNmmv3wu-5s9UB_RFO5Wptdo+a71Lmzn2Zs4kb=MwnFoTctCg@mail.gmail.com>

On Fri, Mar 20, 2015 at 11:15 AM, Jason Karns <karns.17@gmail.com> wrote:
> There appears to be a bug in the bash completion for git-branch when
> attempting to complete the remote ref argument for --set-upstream-to=
>
> When:
>
> $ git branch --set-upstream-to=origin/mast<TAB>
>
> I would expect it to complete to:
>
> $ git branch --set-upstream-to=origin/master
>
> However, the completion for --set-upstream-to= completes the ref
> correctly, but completely wipes the --set-upstream option; resulting
> in:
>
> $ git branch origin/master
>
> I'm running on OS X 10.9.5 with git from homebrew:
> $ bash --version
> GNU bash, version 4.3.33(1)-release (x86_64-apple-darwin13.4.0)

Presumably, your bash is also from homebrew? Stock OS X bash tends to
be quite a bit older.

> $ git --version
> git version 2.3.3

I'm unable to reproduce this problem using git 2.3.3 and bash 4.3.33.

> The same behavior does *not* manifest (it works as expected) on CentOS
> 6.5, bash 4.1.2.1 (GNU bash, version 4.1.2(1)-release
> (x86_64-redhat-linux-gnu)). I'm running git 2.0.3 on CentOs but
> sourcing the shell completion script from latest source: 9ab698f
>
> I also cloned down latest git source on OS X and the bug still
> manifests when sourcing the completion script at 9ab698f.

Perhaps something in your bash startup script(s) is causing a strange
interaction.

  reply	other threads:[~2015-03-22  3:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20 15:15 bug in bash completion for git-branch --set-upstream-to on OSX Jason Karns
2015-03-22  3:24 ` Eric Sunshine [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-03-22 11:06 SZEDER Gábor
2015-03-23 13:45 ` Jason Karns
2015-03-23 14:42   ` Jason Karns

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPig+cRYQfSNvyCXJc2a4wFAsZ8S4v3zvc5K5-fW+guepMeVPg@mail.gmail.com \
    --to=sunshine@sunshineco.com \
    --cc=git@vger.kernel.org \
    --cc=karns.17@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).