git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: Jeff King <peff@peff.net>
Cc: Petr Stodulka <pstodulk@redhat.com>,
	"git@vger.kernel.org" <git@vger.kernel.org>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: Forgotten declaration of function path_name() in revision.h?
Date: Wed, 16 Mar 2016 14:52:03 -0400	[thread overview]
Message-ID: <CAPig+cReEC1swN8oyD68SqHAJhV2i1_CGEO25sJfA-4gA7jP0w@mail.gmail.com> (raw)
In-Reply-To: <20160316184853.GA32615@sigill.intra.peff.net>

On Wed, Mar 16, 2016 at 2:48 PM, Jeff King <peff@peff.net> wrote:
> It makes things easier on the maintainer if you format your patch such
> that "git am" can apply it directly. Use scissors like:
>
> -- >8 --
>
> to separate the patch from anything that should not go into the commit
> message (rather than "=====..." as you have here).
>
> Drop the "From " line which says nothing (it is an mbox separator, but
> we are already inside a message).
>
> The rest of the headers do not hurt, but are generally redundant with
> what is in your email header (though in this case, the Subject is
> different, so you would want to retain that).

Also, Signed-off-by: is missing.

  reply	other threads:[~2016-03-16 18:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-16 18:05 Forgotten declaration of function path_name() in revision.h? Petr Stodulka
2016-03-16 18:48 ` Jeff King
2016-03-16 18:52   ` Eric Sunshine [this message]
2016-03-16 19:08   ` Petr Stodulka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPig+cReEC1swN8oyD68SqHAJhV2i1_CGEO25sJfA-4gA7jP0w@mail.gmail.com \
    --to=sunshine@sunshineco.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=pstodulk@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).