From: Eric Sunshine <sunshine@sunshineco.com>
To: Matthieu Moy <Matthieu.Moy@imag.fr>
Cc: Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
javierdo1@gmail.com, Jonathan Nieder <jrnieder@gmail.com>,
judge.packham@gmail.com
Subject: Re: [PATCH 2/2] commit: disable status hints when writing to COMMIT_EDITMSG
Date: Wed, 11 Sep 2013 05:13:05 -0400 [thread overview]
Message-ID: <CAPig+cRfgSrSMHT0OX0H=uh-Wi3TceU+UN8gUH4La1RTpRLETQ@mail.gmail.com> (raw)
In-Reply-To: <1378890539-1966-2-git-send-email-Matthieu.Moy@imag.fr>
On Wed, Sep 11, 2013 at 5:08 AM, Matthieu Moy <Matthieu.Moy@imag.fr> wrote:
> Most status hints were written to be accurate when running "git status"
> before running a commit. Many of them are not applicable when the commit
> has already been started, and should not be shown in COMMIT_EDITMSG. The
> most obvious are hints advising to run "git commit",
> "git rebase/am/cherry-pick --continue", which do not make sense when the
> command has already been ran.
s/ran/run/
> Other messages become slightly inaccurate (e.g. hint to use "git add" to
> add untracked files), as the suggested commands are not immediately
> applicable during the edition of COMMIT_EDITMSG, but would be applicable
s/edition/editing/
> if the commit is aborted. These messages are both potentially helpful and
> slightly misleading. This patch chose to remove them too, to avoid
> introducing too much complexity in the status code.
>
> Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
next prev parent reply other threads:[~2013-09-11 9:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 9:08 [PATCH 1/2] wt-status: turn advice_status_hints into a field of wt_status Matthieu Moy
2013-09-11 9:08 ` [PATCH 2/2] commit: disable status hints when writing to COMMIT_EDITMSG Matthieu Moy
2013-09-11 9:13 ` Eric Sunshine [this message]
2013-09-11 18:35 ` [PATCH 1/2] wt-status: turn advice_status_hints into a field of wt_status Jeff King
2013-09-12 9:44 ` Matthieu Moy
2013-09-12 9:52 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cRfgSrSMHT0OX0H=uh-Wi3TceU+UN8gUH4La1RTpRLETQ@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=javierdo1@gmail.com \
--cc=jrnieder@gmail.com \
--cc=judge.packham@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).