From: Eric Sunshine <sunshine@sunshineco.com>
To: "Célestin Matte" <celestin.matte@ensimag.fr>
Cc: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
Git List <git@vger.kernel.org>,
benoit.person@ensimag.fr
Subject: Re: [PATCH v5 00/31] Follow perlcritic's recommandations
Date: Wed, 12 Jun 2013 17:23:57 -0400 [thread overview]
Message-ID: <CAPig+cRg4so7W+ddgGg7_ZnKNkoc0T8CqNQOO5a7xnjN1LYvzw@mail.gmail.com> (raw)
In-Reply-To: <51B8DE57.9040205@ensimag.fr>
On Wed, Jun 12, 2013 at 4:47 PM, Célestin Matte
<celestin.matte@ensimag.fr> wrote:
> Le 12/06/2013 22:34, Célestin Matte a écrit :
>>> Célestin Matte <celestin.matte@ensimag.fr> writes:
>> Actually, there still is a problem: the "defined(@array)" (introduced
>> with the change in [21/31]) produces a warning.
>> Benoit also seems to have problems with this patch... I'm waiting for
>> his feedback.
>>
> There is indeed a bug. In patch [21/31], at line 163, it should be
> if (!defined $cmd[0]) {
> instead of
> if (!defined @cmd) {
>
> Should I send yet another version of this series of patch?
Assuming you don't discover more problems, for such a small change in
a lengthy patch series, it might make sense to send a simple "fixup!"
[*1*] patch and ask if Junio would be willing to squash it into v5.
[*1*]: see fixup! in git/Documentation/git-rebase.txt
next prev parent reply other threads:[~2013-06-12 21:24 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 15:43 [PATCH v5 00/31] Follow perlcritic's recommandations Célestin Matte
2013-06-12 15:43 ` [PATCH v5 01/31] git-remote-mediawiki: Make a regexp clearer Célestin Matte
2013-06-12 15:43 ` [PATCH v5 02/31] git-remote-mediawiki: Move "use warnings;" before any instruction Célestin Matte
2013-06-12 15:43 ` [PATCH v5 03/31] git-remote-mediawiki: Replace :utf8 by :encoding(UTF-8) Célestin Matte
2013-06-12 15:43 ` [PATCH v5 04/31] git-remote-mediawiki: Always end a subroutine with a return Célestin Matte
2013-06-12 15:43 ` [PATCH v5 05/31] git-remote-mediawiki: Move a variable declaration at the top of the code Célestin Matte
2013-06-12 15:43 ` [PATCH v5 06/31] git-remote-mediawiki: Change syntax of map calls Célestin Matte
2013-06-12 15:43 ` [PATCH v5 07/31] git-remote-mediawiki: Rewrite unclear line of instructions Célestin Matte
2013-06-12 15:43 ` [PATCH v5 08/31] git-remote-mediawiki: Remove useless regexp modifier (m) Célestin Matte
2013-06-12 15:43 ` [PATCH v5 09/31] git-remote-mediawiki: Change the behaviour of a split Célestin Matte
2013-06-12 15:43 ` [PATCH v5 10/31] git-remote-mediawiki: Change separator of some regexps Célestin Matte
2013-06-12 15:43 ` [PATCH v5 11/31] git-remote-mediawiki: Change style in a regexp Célestin Matte
2013-06-12 15:43 ` [PATCH v5 12/31] " Célestin Matte
2013-06-12 15:43 ` [PATCH v5 13/31] git-remote-mediawiki: Add newline in the end of die() error messages Célestin Matte
2013-06-12 15:43 ` [PATCH v5 14/31] git-remote-mediawiki: Change the name of a variable Célestin Matte
2013-06-12 15:43 ` [PATCH v5 15/31] git-remote-mediawiki: Turn double-negated expressions into simple expressions Célestin Matte
2013-06-12 15:43 ` [PATCH v5 16/31] git-remote-mediawiki: Remove unused variable $entry Célestin Matte
2013-06-12 15:43 ` [PATCH v5 17/31] git-remote-mediawiki: Rename a variable ($last) which has the name of a keyword Célestin Matte
2013-06-12 15:43 ` [PATCH v5 18/31] git-remote-mediawiki: Assign a variable as undef and make proper indentation Célestin Matte
2013-06-12 15:43 ` [PATCH v5 19/31] git-remote-mediawiki: Check return value of open Célestin Matte
2013-06-12 15:43 ` [PATCH v5 20/31] git-remote-mediawiki: remove import of unused open2 Célestin Matte
2013-06-12 15:43 ` [PATCH v5 21/31] git-remote-mediawiki: Put long code into a subroutine Célestin Matte
2013-06-12 15:43 ` [PATCH v5 22/31] git-remote-mediawiki: Modify strings for a better coding-style Célestin Matte
2013-06-12 15:43 ` [PATCH v5 23/31] git-remote-mediawiki: Brace file handles for print for more clarity Célestin Matte
2013-06-12 15:43 ` [PATCH v5 24/31] git-remote-mediawiki: Replace "unless" statements with negated "if" statements Célestin Matte
2013-06-12 15:43 ` [PATCH v5 25/31] git-remote-mediawiki: Don't use quotes for empty strings Célestin Matte
2013-06-12 15:43 ` [PATCH v5 26/31] git-remote-mediawiki: Put non-trivial numeric values in constants Célestin Matte
2013-06-12 15:43 ` [PATCH v5 27/31] git-remote-mediawiki: Fix a typo ("mediwiki" instead of "mediawiki") Célestin Matte
2013-06-12 15:43 ` [PATCH v5 28/31] git-remote-mediawiki: Clearly rewrite double dereference Célestin Matte
2013-06-12 15:43 ` [PATCH v5 29/31] git-remote-mediawiki: Add a .perlcriticrc file Célestin Matte
2013-06-12 15:43 ` [PATCH v5 30/31] git-remote-mediawiki: add a perlcritic rule in Makefile Célestin Matte
2013-06-12 15:43 ` [PATCH v5 31/31] git-remote-mediawiki: Make error message more precise Célestin Matte
2013-06-12 20:02 ` [PATCH v5 00/31] Follow perlcritic's recommandations Matthieu Moy
2013-06-12 20:34 ` Célestin Matte
2013-06-12 20:47 ` Célestin Matte
2013-06-12 21:23 ` Eric Sunshine [this message]
2013-06-12 21:12 ` Matthieu Moy
2013-06-12 21:15 ` Célestin Matte
2013-06-12 22:53 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cRg4so7W+ddgGg7_ZnKNkoc0T8CqNQOO5a7xnjN1LYvzw@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=benoit.person@ensimag.fr \
--cc=celestin.matte@ensimag.fr \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).