From: Eric Sunshine <sunshine@sunshineco.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/5] pack-bitmap: load writer config from repository parameter
Date: Sat, 17 Aug 2024 03:33:06 -0400 [thread overview]
Message-ID: <CAPig+cRgJkXxESSL4h+LO5FKcxKf6pt5VBWpjfUAZrrB5b0Kww@mail.gmail.com> (raw)
In-Reply-To: <20240817072653.GB1535915@coredump.intra.peff.net>
On Sat, Aug 17, 2024 at 3:27 AM Jeff King <peff@peff.net> wrote:
> In bitmap_writer_init(), we take a repository parameter but ever look at
s/ever/never/
> it. Most of the initialization here is independent of the repository,
> but we do load some config. So let's pass the repo we get down to
> load_pseudo_merges_from_config(), which in turn can use repo_config(),
> rather than depending on the_repository via git_config().
>
> The outcome is the same, since all callers pass in the_repository
> anyway. But it takes us a step closer to getting rid of the global, and
> as a bonus it silences an unused parameter warning.
>
> Signed-off-by: Jeff King <peff@peff.net>
next prev parent reply other threads:[~2024-08-17 7:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-17 7:26 [PATCH 0/5] dropping some more unused parameters Jeff King
2024-08-17 7:26 ` [PATCH 1/5] refs: drop some unused parameters from create_symref_lock() Jeff King
2024-08-17 7:26 ` [PATCH 2/5] pack-bitmap: load writer config from repository parameter Jeff King
2024-08-17 7:33 ` Eric Sunshine [this message]
2024-08-17 7:29 ` [PATCH 3/5] pack-bitmap: drop unused parameters from select_pseudo_merges() Jeff King
2024-08-17 7:29 ` [PATCH 4/5] ref-filter: drop unused parameters from email_atom_option_parser() Jeff King
2024-08-17 7:29 ` [PATCH 5/5] diff-lib: drop unused index argument from get_stat_data() Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cRgJkXxESSL4h+LO5FKcxKf6pt5VBWpjfUAZrrB5b0Kww@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).