Re: [PATCH v5 00/23] Signed push

[Eric Sunshine <sunshine@sunshineco.com>]

On Tuesday, September 16, 2014, Junio C Hamano <gitster@pobox.com> wrote:
>
> Junio C Hamano <gitster@pobox.com> writes:
>
> > A failing test has been added at the end for smart HTTP.  It appears
> > that somewhere in the callchain "--signed" is forgotten and the
> > sending end not to send the certificate for some reason.  If
> > somebody with a fresh set of eyes can look into it, that would be
> > very much appreciated, as I do not expect I would have sufficient
> > concentration to dig it quickly for several days at least.
>
> I lied.  This is to replace the patch at the end (23/23).
>
> -- >8 --
> From: Junio C Hamano <gitster@pobox.com>
> Date: Mon, 15 Sep 2014 14:59:00 -0700
> Subject: [PATCH] push: teach smart-HTTP to pass "git push --signed" around
>
> The "--signed" option received by "git push" is first passed to the
> transport layer, which the native transport directly uses to notice
> that a push certificate needs to be sent.  When the transport-helper
> is involved, however, the option needs to be told to the helper with
> set_helper_option(), and the helepr needs to take necessary action.

s/helepr/helper/

> For the smart-HTTP helper, the "necessary action" involves spawning
> the "git send-pack" subprocess with the "--signed" option.
>
> Once the above all gets wired in, the smart-HTTP transport now can
> use the push certificate mechanism to authenticate its pushes.
>
> Add a test that is modeled after tests for the native transport in
> t5534-push-signed.sh to t5541-http-push-smart.sh.  Update the test
> Apache configuration to pass GNUPGHOME environment variable through.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>