git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: Mark Strapetz <marc.strapetz@syntevo.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH] Documentation: declare "core.ignorecase" as internal variable
Date: Sun, 24 Jun 2018 06:19:16 -0400	[thread overview]
Message-ID: <CAPig+cRu8UGVB3MYNRN_Jn0w8Vn=+WdG488hmaePzP=ibtU3TQ@mail.gmail.com> (raw)
In-Reply-To: <7f6b2a42-334d-9443-7b89-625069931ca7@syntevo.com>

On Sun, Jun 24, 2018 at 6:05 AM Marc Strapetz <marc.strapetz@syntevo.com> wrote:
> The current description of "core.ignorecase" reads like an option which
> is intended to be changed by the user while it's actually expected to
> be set by Git only [1].
>
> [1] https://marc.info/?l=git&m=152972992729761&w=2

Thanks for following up the discussion with a patch.

The commit message, unfortunately, doesn't explain the "why" of this
change in enough detail for someone to understand the issue without
chasing down that link (which could go stale, or the reader might be
offline). Incorporating Bryan's explanation[1] directly into the
commit message would likely be a good idea if you happen to re-roll.

    Git on Windows is not designed to run with anything other than
    core.ignoreCase=true, and attempting to do so will cause
    unexpected behavior. In other words, it's not a behavior toggle so
    user's can request the functionality to work one way or the other;
    it's an implementation detail that `git init` and `git clone` set
    when a repository is created purely so they don't have to probe
    the file system each time you run a `git` command.

[1]: https://public-inbox.org/git/CAGyf7-GvcN8EhMgtaZcDJNYNdfLwVH8HVBDmZqJU40nze0NSEA@mail.gmail.com/

> Signed-off-by: Marc Strapetz <marc.strapetz@syntevo.com>

  reply	other threads:[~2018-06-24 10:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-24 10:05 [PATCH] Documentation: declare "core.ignorecase" as internal variable Marc Strapetz
2018-06-24 10:19 ` Eric Sunshine [this message]
2018-06-24 10:44 ` [PATCH v2] " Marc Strapetz
2018-06-24 11:26   ` Sascha Silbe
2018-06-24 13:47   ` Torsten Bögershausen
2018-06-26 21:50 ` [PATCH v3] " Marc Strapetz
2018-06-27 19:11   ` Junio C Hamano
2018-06-27 23:09     ` Aaron Schrab
2018-06-28 11:36     ` Marc Strapetz
2018-06-28 11:21 ` [PATCH v4] Documentation: declare "core.ignoreCase" " Marc Strapetz
2018-06-28 16:47   ` Junio C Hamano
2018-06-28 16:58   ` Torsten Bögershausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPig+cRu8UGVB3MYNRN_Jn0w8Vn=+WdG488hmaePzP=ibtU3TQ@mail.gmail.com' \
    --to=sunshine@sunshineco.com \
    --cc=git@vger.kernel.org \
    --cc=marc.strapetz@syntevo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).