Re: [PATCH v2 3/3] chainlint: reduce annotation noise-factor

[Eric Sunshine <sunshine@sunshineco.com>]

On Tue, Sep 10, 2024 at 11:42 AM Junio C Hamano <gitster@pobox.com> wrote:
> Eric Sunshine <sunshine@sunshineco.com> writes:
> > On Tue, Sep 10, 2024 at 3:48 AM Patrick Steinhardt <ps@pks.im> wrote:
> >> One thing I don't like about this is that we now have different output
> >> depending on whether or not you happen to pipe output to e.g. less(1),
> >> which I do quite frequently. So I'd propose to just drop the markers
> >> unconditionally.
> >
> > My knee-jerk reaction is that the "?!" decoration is still handy for
> > drawing the eye when scanning non-colored output visually (not using a
> > search feature), so I'm hesitant to drop it. However, on reflection,
> > I'm not sure I feel very strongly about it. What do others think?
>
> Unlike ERR, LINT is distinct enough, even when mixed with snippets
> taken from the test scripts that are full of words that hints
> errors, checking, etc., so I'd expect that new readers who have
> never seen the "?!" eye-magnets would not find the output too hard
> to read.  For those of us whose eyes are so used to, we might miss
> them for a while, but I do not see much upside in keeping it.

Okay, thanks for weighing in. I'll reroll and make [3/3] drop the "?!"
decoration unconditionally.