git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: Han-Wen Nienhuys <hanwen@google.com>
Cc: Junio C Hamano <gitster@pobox.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] Document git config getter return value.
Date: Wed, 1 Aug 2018 04:24:01 -0400	[thread overview]
Message-ID: <CAPig+cRv5sHSoAPVi=Dnu2HXcbGThdMsgOfvs-Kh2NbnGg-j8w@mail.gmail.com> (raw)
In-Reply-To: <20180731173651.184716-2-hanwen@google.com>

On Tue, Jul 31, 2018 at 1:37 PM Han-Wen Nienhuys <hanwen@google.com> wrote:
> diff --git a/config.h b/config.h
> @@ -178,10 +178,16 @@ struct config_set {
> +/*
> + * The int return values in the functions is 1 if not found, 0 if found, leaving
> + * the found value in teh 'dest' pointer.
> + */

"teh"?

Instead of talking about "the int return values", simpler would be to
say "returns 1 if ...; else 0". Not worth a re-roll, though.

> +extern int git_configset_add_file(struct config_set *cs, const char *filename);
> +extern int git_configset_get_value(struct config_set *cs, const char *key, const char **dest);

  reply	other threads:[~2018-08-01  8:24 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-31 17:36 [PATCH 0/2 v3] Highlight keywords in remote sideband output Han-Wen Nienhuys
2018-07-31 17:36 ` [PATCH 1/2] Document git config getter return value Han-Wen Nienhuys
2018-08-01  8:24   ` Eric Sunshine [this message]
2018-07-31 17:36 ` [PATCH 2/2] Highlight keywords in remote sideband output Han-Wen Nienhuys
2018-07-31 19:45   ` Junio C Hamano
2018-07-31 20:21   ` Eric Sunshine
2018-08-01 15:41     ` Junio C Hamano
2018-08-01 17:18       ` Han-Wen Nienhuys
2018-08-01 18:16         ` Junio C Hamano
2018-08-02  7:34           ` Han-Wen Nienhuys
2018-08-02 10:24           ` Eric Sunshine
2018-08-02 11:46             ` Han-Wen Nienhuys
2018-08-02 17:37               ` Eric Sunshine
2018-08-02 17:44                 ` Stefan Beller
2018-08-02 11:43     ` Han-Wen Nienhuys
  -- strict thread matches above, loose matches on Subject: below --
2018-07-30 12:26 [PATCH 1/2] Document git config getter return value Han-Wen Nienhuys
2018-07-30 18:48 ` Eric Sunshine
2018-07-30 20:03   ` Junio C Hamano
2018-07-30 12:18 Han-Wen Nienhuys

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPig+cRv5sHSoAPVi=Dnu2HXcbGThdMsgOfvs-Kh2NbnGg-j8w@mail.gmail.com' \
    --to=sunshine@sunshineco.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=hanwen@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).