From: Eric Sunshine <sunshine@sunshineco.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] ewah: use less generic macro name
Date: Wed, 3 Jun 2015 02:51:20 -0400 [thread overview]
Message-ID: <CAPig+cRySp4_uJYAwC-PY_Yh-YjBb0y1Tq=TwoD7d-Bpb_YANg@mail.gmail.com> (raw)
In-Reply-To: <20150603063937.GB29008@peff.net>
On Wed, Jun 3, 2015 at 2:39 AM, Jeff King <peff@peff.net> wrote:
> The ewah/ewok.h header pollutes the global namespace with
> "BITS_IN_WORD", without any specific notion that we are
> talking about the bits in an eword_t. We can give this the
> more specific name "BITS_IN_EWORD".
>
> Signed-off-by: Jeff King <peff@peff.net>
Yeah, splitting the patches this way makes sense and feels a bit cleaner.
It's such a simple patch that it doesn't need a reviewed-by, but for
what it's worth...
Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>
next prev parent reply other threads:[~2015-06-03 6:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 21:47 [PATCH] ewah/bitmap: silence warning about MASK macro redefinition Eric Sunshine
2015-06-02 22:15 ` Junio C Hamano
2015-06-03 4:51 ` Jeff King
2015-06-03 6:28 ` Eric Sunshine
2015-06-03 6:38 ` Jeff King
2015-06-03 6:39 ` [PATCH 1/2] " Jeff King
2015-06-03 6:46 ` Eric Sunshine
2015-06-03 6:39 ` [PATCH 2/2] ewah: use less generic macro name Jeff King
2015-06-03 6:51 ` Eric Sunshine [this message]
2015-06-03 6:50 ` [PATCH] ewah/bitmap: silence warning about MASK macro redefinition Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cRySp4_uJYAwC-PY_Yh-YjBb0y1Tq=TwoD7d-Bpb_YANg@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).