git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: Santiago Torres <santiago@nyu.edu>
Cc: Git List <git@vger.kernel.org>,
	Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>
Subject: Re: [PATCH v7 0/6] Move PGP verification out of verify-tag
Date: Tue, 19 Apr 2016 15:10:00 -0400	[thread overview]
Message-ID: <CAPig+cRz4stVQWFD-NroVHft2xFvyZJi1ePX9T4zZ3k3=X6ZrA@mail.gmail.com> (raw)
In-Reply-To: <1461088041-19264-1-git-send-email-santiago@nyu.edu>

On Tue, Apr 19, 2016 at 1:47 PM,  <santiago@nyu.edu> wrote:
> This is a follow up of [1], [2], [3], [4], [5], [6]. patches 1/6, 2/6, are the
> same as the corresponding commits in pu.
>
> v7:
> Mostly style/clarity changes mostly. Thanks Peff, Eric and Junio for the
> feedback! In summary:
>
>  * Eric pointed out issues with 3/6's commit message. It doesn't match the one
>    in pu though. I also took the opportunity to update payload_size to a size_t
>    as Peff suggested.
>  * 4/6 I updated report_name to name_to_report, I updated the commit message
>    and addressed some nits in the code, one of the fixes removed all three nits
>    that Eric pointed out. I updated 5/6 to match these changes
>  * I gave the commit message on 6/6 another go.

Thanks, this re-roll looks good. My reviews mention a couple nits, but
I hope they are not worth a re-roll (perhaps Junio can address them
when/if he picks up the series).

As before, the entire series is:

    Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>

      parent reply	other threads:[~2016-04-19 19:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-19 17:47 [PATCH v7 0/6] Move PGP verification out of verify-tag santiago
2016-04-19 17:47 ` [PATCH v7 1/6] builtin/verify-tag.c: ignore SIGPIPE in gpg-interface santiago
2016-04-19 17:47 ` [PATCH v7 2/6] t7030: test verifying multiple tags santiago
2016-04-19 17:47 ` [PATCH v7 3/6] verify-tag: update variable name and type santiago
2016-04-19 17:47 ` [PATCH v7 4/6] verify-tag: prepare verify_tag for libification santiago
2016-04-19 19:05   ` Eric Sunshine
2016-04-19 19:36     ` Junio C Hamano
2016-04-19 17:47 ` [PATCH v7 5/6] verify-tag: move tag verification code to tag.c santiago
2016-04-19 17:47 ` [PATCH v7 6/6] tag -v: verfy directly rather than exec-ing verify-tag santiago
2016-04-19 19:06   ` Eric Sunshine
2016-04-19 19:10 ` Eric Sunshine [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPig+cRz4stVQWFD-NroVHft2xFvyZJi1ePX9T4zZ3k3=X6ZrA@mail.gmail.com' \
    --to=sunshine@sunshineco.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=santiago@nyu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).