From: Eric Sunshine <sunshine@sunshineco.com>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: Git List <git@vger.kernel.org>,
Christian Couder <christian.couder@gmail.com>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Subject: Re: [PATCH v4 04/19] for-each-ref: add '--points-at' option
Date: Mon, 22 Jun 2015 18:38:18 -0400 [thread overview]
Message-ID: <CAPig+cRzZDa4LyEpzVcODYCdwxoHPRJ3hqjEvSWdBsKi3Ti7nA@mail.gmail.com> (raw)
In-Reply-To: <1434919705-4884-4-git-send-email-karthik.188@gmail.com>
On Sun, Jun 21, 2015 at 4:48 PM, Karthik Nayak <karthik.188@gmail.com> wrote:
> Add the '--points-at' option provided by 'ref-filter'. The
> option lets the user to pick only refs which point to a particular
> commit.
>
> Add documentation and tests for the same.
>
> Based-on-patch-by: Jeff King <peff@peff.net>
> Mentored-by: Christian Couder <christian.couder@gmail.com>
> Mentored-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
> ---
> diff --git a/t/t6301-for-each-ref-filter.sh b/t/t6301-for-each-ref-filter.sh
> index b1fa8d4..67de3a7 100755
> --- a/t/t6301-for-each-ref-filter.sh
> +++ b/t/t6301-for-each-ref-filter.sh
> @@ -16,4 +16,24 @@ test_expect_success 'setup some history and refs' '
> git update-ref refs/odd/spot master
> '
>
> +test_expect_success 'filtering with --points-at' '
> + cat >expect <<-\EOF &&
> + refs/heads/master
> + refs/odd/spot
> + refs/tags/three
> + EOF
> + git for-each-ref --format="%(refname)" --points-at=master >actual &&
> + test_cmp expect actual
> +'
> +
> +test_expect_success 'check signed tags with --points-at' '
> + cat >expect <<-\EOF &&
> + refs/heads/side
> + refs/tags/four
> + refs/tags/signed-tag four
> + EOF
> + git for-each-ref --format="%(refname) %(*subject)" --points-at=side >actual &&
s/for-each-ref\s+/for-each-ref /
> + test_cmp expect actual
> +'
> +
> test_done
> --
> 2.4.3.439.gfea0c2a.dirty
next prev parent reply other threads:[~2015-06-22 22:38 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-21 20:45 [PATCH v4 00/11] add options to for-each-ref Karthik Nayak
2015-06-21 20:48 ` [PATCH v4 01/19] t6301: for-each-ref tests for ref-filter APIs Karthik Nayak
2015-06-21 20:48 ` [PATCH v4 02/19] tag: libify parse_opt_points_at() Karthik Nayak
2015-06-21 20:48 ` [PATCH v4 03/19] ref-filter: implement '--points-at' option Karthik Nayak
2015-06-22 22:36 ` Eric Sunshine
2015-06-23 10:49 ` Karthik Nayak
2015-06-21 20:48 ` [PATCH v4 04/19] for-each-ref: add " Karthik Nayak
2015-06-22 0:45 ` Junio C Hamano
2015-06-22 19:03 ` Karthik Nayak
2015-06-22 19:21 ` Matthieu Moy
2015-06-22 19:24 ` Junio C Hamano
2015-06-22 19:27 ` Karthik Nayak
2015-06-22 19:51 ` Junio C Hamano
2015-06-22 22:38 ` Eric Sunshine [this message]
2015-06-23 10:52 ` Karthik Nayak
2015-06-21 20:48 ` [PATCH v4 05/19] ref-filter: add parse_opt_merge_filter() Karthik Nayak
2015-06-22 0:55 ` Junio C Hamano
2015-06-22 11:13 ` Matthieu Moy
2015-06-22 16:15 ` Junio C Hamano
2015-06-22 19:00 ` Karthik Nayak
2015-06-21 20:48 ` [PATCH v4 06/19] ref-filter: implement '--merged' and '--no-merged' options Karthik Nayak
2015-06-22 1:00 ` Junio C Hamano
2015-06-22 15:11 ` Karthik Nayak
2015-06-21 20:48 ` [PATCH v4 07/19] for-each-ref: add " Karthik Nayak
2015-06-22 22:41 ` Eric Sunshine
2015-06-23 11:05 ` Karthik Nayak
2015-06-21 20:48 ` [PATCH v4 08/19] parse-option: rename parse_opt_with_commit() Karthik Nayak
2015-06-22 1:04 ` Junio C Hamano
2015-06-22 15:38 ` Karthik Nayak
2015-06-22 16:27 ` Junio C Hamano
2015-06-22 16:37 ` Karthik Nayak
2015-06-21 20:48 ` [PATCH v4 09/19] parse-options.h: add macros for '--contains' option Karthik Nayak
2015-06-21 20:48 ` [PATCH v4 10/19] ref-filter: implement " Karthik Nayak
2015-06-21 20:48 ` [PATCH v4 11/19] for-each-ref: add " Karthik Nayak
2015-06-21 20:51 ` [PATCH v4 00/11] add options to for-each-ref Karthik Nayak
2015-06-22 0:41 ` Junio C Hamano
2015-06-22 14:48 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cRzZDa4LyEpzVcODYCdwxoHPRJ3hqjEvSWdBsKi3Ti7nA@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).