From: Eric Sunshine <sunshine@sunshineco.com>
To: Denton Liu <liu.denton@gmail.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH 3/3] format-patch: infer cover letter from branch description
Date: Mon, 19 Aug 2019 13:29:26 -0400 [thread overview]
Message-ID: <CAPig+cS1xqO3w9dAmYpHSCJJyquWRhJgYOpasScafabGEYuVWg@mail.gmail.com> (raw)
In-Reply-To: <5cc5e354b6d84609f3d1de087b3390488abe5343.1566182184.git.liu.denton@gmail.com>
On Sun, Aug 18, 2019 at 10:37 PM Denton Liu <liu.denton@gmail.com> wrote:
> We used to populate the subject of the cover letter generated by
> git-format-patch with "*** SUBJECT HERE ***". However, if a user submits
> multiple patchsets, they may want to keep a consistent subject between
> rerolls.
>
> If git-format-patch is run with `--infer-cover-letter` or
> `format.inferCoverSubject`, infer the subject for the cover letter from
> the top line(s) of a branch description, similar to how a subject is
> read from a commit message.
>
> Signed-off-by: Denton Liu <liu.denton@gmail.com>
> ---
> diff --git a/Documentation/config/format.txt b/Documentation/config/format.txt
> @@ -36,6 +36,11 @@ format.subjectPrefix::
> +format.inferCoverSubject::
> + A boolean that controls whether or not to infer the subject for
> + the cover letter based on the branch's description. See the
> + --infer-cover-subject option in linkgit:git-format-patch[1].
What is the default value?
prev parent reply other threads:[~2019-08-19 17:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 2:37 [PATCH 0/3] format-patch: teach --infer-cover-subject option Denton Liu
2019-08-19 2:37 ` [PATCH 1/3] t4014: clean up style Denton Liu
2019-08-19 16:02 ` Eric Sunshine
2019-08-19 2:37 ` [PATCH 2/3] Doc: add more detail for git-format-patch Denton Liu
2019-08-19 17:09 ` Eric Sunshine
2019-08-19 23:16 ` Denton Liu
2019-08-20 19:01 ` Junio C Hamano
2019-08-19 2:37 ` [PATCH 3/3] format-patch: infer cover letter from branch description Denton Liu
2019-08-19 17:29 ` Eric Sunshine [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cS1xqO3w9dAmYpHSCJJyquWRhJgYOpasScafabGEYuVWg@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=liu.denton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).