Re: [PATCH v3 3/5] Documentation: add git-log --merges= option and log.merges config. var

[Eric Sunshine <sunshine@sunshineco.com>]

On Wed, Apr 15, 2015 at 6:27 PM, Koosha Khajehmoogahi <koosha@posteo.de> wrote:
> On 04/14/2015 08:42 AM, Eric Sunshine wrote:
>> On Mon, Apr 13, 2015 at 11:29 AM, Koosha Khajehmoogahi <koosha@posteo.de> wrote:
>>> From: Junio C Hamano <gitster@pobox.com>
>>>
>>> [kk: added documentation in git-log.txt]
>>>
>>> Signed-off-by: Koosha Khajehmoogahi <koosha@posteo.de>
>>> ---
>>> @@ -96,6 +96,23 @@ if it is part of the log message.
>>>  --remove-empty::
>>>         Stop when a given path disappears from the tree.
>>>
>>> +--merges={show|hide|only}::
>>> +
>>> +       Limit the output by type of commits.
>>> +
>>> +       `hide`;;
>>> +               Hide merge commits from the output.
>>> +
>>> +       `only`;;
>>> +               Hide non-merge commits from the output (i.e showing
>>> +               only merge commits).
>>> +
>>> +       `show`;;
>>> +               Do not hide either merge or non-merge commits. This
>>> +               is primarily useful when the user has non-standard
>>> +               setting of `log.merges` configuration variable that
>>> +               needs to be overriden from the command line.
>>
>> s/overriden/overridden/
>
> Should I send a new reroll or wait for reviews on my other commits.
> I have not received any review on other patches of this series yet.

Lack of review comments does not necessarily mean that people did not
review the patches; it could mean that reviewers had nothing more to
say. In addition to pointing out the typo above, I also made a small
comment[1] on patch 4/5, but otherwise did not find anything else
about which to comment.

Whether or not you should re-send is something Junio can answer. He
will sometimes silently pick up a series as-is or sometimes silently
make minor fixes based upon review comments. Check his 'pu' branch
periodically to see if your series appears there and if it has those
minor adjustments. If not, and if he doesn't answer this question,
then you may need to re-roll.

[1]: http://article.gmane.org/gmane.comp.version-control.git/267118