From: Eric Sunshine <sunshine@sunshineco.com>
To: Phillip Wood <phillip.wood@dunelm.org.uk>
Cc: git@vger.kernel.org, "René Scharfe" <l.s.r@web.de>,
"Phillip Wood" <phillip.wood123@gmail.com>
Subject: Re: [PATCH 2/3] git-compat-util: convert string predicates to return bool
Date: Mon, 14 Jul 2025 12:46:02 -0400 [thread overview]
Message-ID: <CAPig+cS=tEO90WnATueFM8FumHcq9HkPrfa_JUCzeMkDaLsYdw@mail.gmail.com> (raw)
In-Reply-To: <a0f9182aa20d0f956072a3d185a2d1288f1bd842.1752499610.git.phillip.wood@dunelm.org.uk>
On Mon, Jul 14, 2025 at 9:31 AM Phillip Wood <phillip.wood123@gmail.com> wrote:
> Since 8277dbe987 (git-compat-util: convert skip_{prefix,suffix}{,_mem}
> to bool, 2023-12-16) a number of our sting predicates have been
s/sting/string/
> returning bool instead of int. Now we've declared that experiment
> a success lets convert the return type the case independent
s/lets/let's/
/type/& of/
> skip_iprefix() and skip_iprefix_mem() functions to match the return
> type of their case dependent equivalents. Returning bool instead of
> int makes it clear that these functions are predicates.
>
> Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
next prev parent reply other threads:[~2025-07-14 16:46 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 13:26 [PATCH 0/3] C99: declare bool experiment a success Phillip Wood
2025-07-14 13:27 ` [PATCH 1/3] CodingGuildlines: allow the use of bool Phillip Wood
2025-07-14 16:37 ` Junio C Hamano
2025-07-14 13:27 ` [PATCH 2/3] git-compat-util: convert string predicates to return bool Phillip Wood
2025-07-14 16:46 ` Eric Sunshine [this message]
2025-07-14 17:20 ` Elijah Newren
2025-07-14 21:14 ` brian m. carlson
2025-07-15 9:36 ` Phillip Wood
2025-07-14 13:27 ` [PATCH 3/3] strbuf: convert " Phillip Wood
2025-07-15 13:52 ` [PATCH v2 0/3] C99: declare bool experiment a success Phillip Wood
2025-07-15 13:52 ` [PATCH v2 1/3] CodingGuildlines: allow the use of bool Phillip Wood
2025-07-16 4:38 ` Jeff King
2025-07-16 4:46 ` Jeff King
2025-07-16 5:06 ` Elijah Newren
2025-07-15 13:52 ` [PATCH v2 2/3] git-compat-util: convert string predicates to return bool Phillip Wood
2025-07-15 13:52 ` [PATCH v2 3/3] strbuf: convert " Phillip Wood
2025-07-15 17:19 ` [PATCH v2 0/3] C99: declare bool experiment a success Elijah Newren
2025-07-15 18:23 ` rsbecker
2025-07-15 19:35 ` Elijah Newren
2025-07-15 20:47 ` rsbecker
2025-07-15 21:06 ` Junio C Hamano
2025-07-15 18:53 ` Junio C Hamano
2025-07-15 21:48 ` brian m. carlson
2025-07-15 22:09 ` Junio C Hamano
2025-07-16 9:38 ` [PATCH v3 " Phillip Wood
2025-07-16 9:38 ` [PATCH v3 1/3] CodingGuidelines: allow the use of bool Phillip Wood
2025-07-16 9:38 ` [PATCH v3 2/3] git-compat-util: convert string predicates to return bool Phillip Wood
2025-07-16 10:26 ` Karthik Nayak
2025-07-16 9:38 ` [PATCH v3 3/3] strbuf: convert " Phillip Wood
2025-07-16 10:28 ` Karthik Nayak
2025-07-16 10:29 ` [PATCH v3 0/3] C99: declare bool experiment a success Karthik Nayak
2025-07-17 15:21 ` Phillip Wood
2025-07-22 8:09 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cS=tEO90WnATueFM8FumHcq9HkPrfa_JUCzeMkDaLsYdw@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=phillip.wood123@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).