Re: [PATCH v3 4/6] [Newcomer] t7004-tag: do not prepare except outside test_expect_success

[Eric Sunshine <sunshine@sunshineco.com>]

On Sun, Aug 4, 2024 at 3:12 AM AbdAlRahman Gad <abdobngad@gmail.com> wrote:
> do not prepare expect outside test_expect_success
>
> Signed-off-by: AbdAlRahman Gad <abdobngad@gmail.com>
> ---
> diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
> @@ -131,10 +131,10 @@ test_expect_success 'listing all tags if one exists should succeed' '
> -cat >expect <<EOF
> -mytag
> -EOF
>  test_expect_success 'Multiple -l or --list options are equivalent to one -l option' '
> +       cat >expect <<-\EOF &&
> +       mytag
> +       EOF
>         git tag -l -l >actual &&

This patch also changes bare `EOF` to `\EOF` which correctly signals
to the reader that no variable interpolation or other processing is
happening inside the here-doc body. Such a change of semantics is
significant enough that it normally warrants mention in the commit
message. In fact, often the `EOF` to `\EOF` change would be done in
its own commit. However, it's probably not worth a reroll in this
case; v3 is likely a good place to stop unless a reviewer finds a
problem which demands v4.