From: Eric Sunshine <sunshine@sunshineco.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Git List <git@vger.kernel.org>, Max Kirillov <max@max630.net>
Subject: Re: [PATCH] t5562: avoid non-portable "export FOO=bar" construct
Date: Sat, 28 Jul 2018 23:13:13 -0400 [thread overview]
Message-ID: <CAPig+cSCsOXi4e8idXwLo41rjDREvvtG5P_bNtEWybUbAZj9Hg@mail.gmail.com> (raw)
In-Reply-To: <c5b2a072-5058-0d3e-8fb0-52b84bfcdfa9@ramsayjones.plus.com>
On Sat, Jul 28, 2018 at 6:51 PM Ramsay Jones
<ramsay@ramsayjones.plus.com> wrote:
> Commit 6c213e863a ("http-backend: respect CONTENT_LENGTH for
> receive-pack", 2018-07-27) adds a test which uses the non-portable
> export construct. Replace it with "FOO=bar && export FOO" instead.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
> Could you please put this on top of the 'mk/http-backend-content-length'
> branch. This test tickles the new "export FOO=bar" check, so the test
> suite does not run otherwise.
The "export FOO=bar" check comes from 9968ffff0d (test-lint: detect
'export FOO=bar', 2013-07-08), so is not exactly new.
Perhaps you were thinking of [1] a0a630192d
(t/check-non-portable-shell: detect "FOO=bar shell_func", 2018-07-13),
when you wrote this, though it is not related to "export FOO=bar"
detection.
The patch itself looks fine, by the way.
[1]: https://public-inbox.org/git/20180713055205.32351-5-sunshine@sunshineco.com/
next prev parent reply other threads:[~2018-07-29 3:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-28 22:51 [PATCH] t5562: avoid non-portable "export FOO=bar" construct Ramsay Jones
2018-07-29 3:13 ` Eric Sunshine [this message]
2018-07-29 15:32 ` Ramsay Jones
2018-07-30 3:55 ` Max Kirillov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cSCsOXi4e8idXwLo41rjDREvvtG5P_bNtEWybUbAZj9Hg@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=max@max630.net \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).