git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: Ian Wienand <iwienand@redhat.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] alias: document caveats and add trace of prepared command
Date: Tue, 21 May 2024 23:29:43 -0400	[thread overview]
Message-ID: <CAPig+cSDZzwH5RLYXbUXvdePHUtrPDDEdapQakB22zBkO25kuw@mail.gmail.com> (raw)
In-Reply-To: <20240522024133.1108005-1-iwienand@redhat.com>

On Tue, May 21, 2024 at 10:42 PM Ian Wienand <iwienand@redhat.com> wrote:
> [...]
> For a "split" alias, e.g. test = "!echo $*" you will see
>
>  $ GIT_TRACE=1 git test hello
>  11:00:45.959420 git.c:755               trace: exec: git-test hello
>  11:00:45.959737 run-command.c:657       trace: run_command: git-test hello
>  11:00:45.961424 run-command.c:657       trace: run_command: 'echo $*' hello
>  11:00:45.961528 run-command.c:437       trace: prepare_cmd: /bin/sh -c 'echo $* "$@"' 'echo $*' hello
>  hello hello
>
> which clearly shows you the appended "$@".  This can be very helpful
> when an alias is giving you an unexpected synatx error that is very

s/synatx/syntax/

> difficult figure out from only the run_command trace point,
> e.g. test = "!for i in 1 2 3; do echo $i; done"
> [...]
> Signed-off-by: Ian Wienand <iwienand@redhat.com>

  reply	other threads:[~2024-05-22  3:29 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22  2:41 [PATCH] alias: document caveats and add trace of prepared command Ian Wienand
2024-05-22  3:29 ` Eric Sunshine [this message]
2024-05-22 16:07 ` Junio C Hamano
2024-05-23  0:38   ` Ian Wienand
2024-05-23  4:20 ` [PATCH v2 1/3] Documentation: alias: rework notes into points Ian Wienand
2024-05-23  4:20   ` [PATCH v2 2/3] Documentation: alias: add notes on shell expansion Ian Wienand
2024-05-23  4:20   ` [PATCH v2 3/3] run-command: show prepared command Ian Wienand
2024-05-23  4:27   ` [PATCH v2 1/3] Documentation: alias: rework notes into points Eric Sunshine
2024-05-23  4:39     ` Ian Wienand
2024-05-23  4:37   ` [PATCH v3 " Ian Wienand
2024-05-23  4:37     ` [PATCH v3 2/3] Documentation: alias: add notes on shell expansion Ian Wienand
2024-05-23  4:37     ` [PATCH v3 3/3] run-command: show prepared command Ian Wienand
2024-05-23 15:29       ` Junio C Hamano
2024-05-23 23:40         ` Junio C Hamano
2024-05-24  6:09           ` Junio C Hamano
2024-05-24  7:18             ` Ian Wienand
2024-05-24 15:33               ` Junio C Hamano
2024-05-24  0:43         ` Ian Wienand
2024-05-24 17:50           ` Junio C Hamano
2024-05-25  1:13             ` Ian Wienand
2024-05-23 15:14     ` [PATCH v3 1/3] Documentation: alias: rework notes into points Junio C Hamano
2024-05-24  7:32     ` [PATCH v4 " Ian Wienand
2024-05-24  7:32       ` [PATCH v4 2/3] Documentation: alias: add notes on shell expansion Ian Wienand
2024-05-24  7:32       ` [PATCH v4 3/3] run-command: show prepared command Ian Wienand
2024-05-24 19:16         ` Junio C Hamano
2024-05-24 19:58           ` Junio C Hamano
2024-05-25  1:14           ` Ian Wienand
2024-05-25  1:20       ` [PATCH v5 1/3] Documentation: alias: rework notes into points Ian Wienand
2024-05-25  1:20         ` [PATCH v5 2/3] Documentation: alias: add notes on shell expansion Ian Wienand
2024-05-25  1:20         ` [PATCH v5 3/3] run-command: show prepared command Ian Wienand
2024-05-25  5:44           ` Junio C Hamano
2024-05-25  6:06           ` Junio C Hamano
2024-05-25 23:49             ` Ian Wienand
2024-05-25 23:44         ` [PATCH v6 1/3] Documentation: alias: rework notes into points Ian Wienand
2024-05-25 23:44           ` [PATCH v6 2/3] Documentation: alias: add notes on shell expansion Ian Wienand
2024-05-26 23:26             ` Junio C Hamano
2024-05-27  0:22               ` Ian Wienand
2024-05-25 23:44           ` [PATCH v6 3/3] run-command: show prepared command Ian Wienand
2024-05-26 16:20             ` Junio C Hamano
2024-05-27  0:30           ` [PATCH v7 1/3] Documentation: alias: rework notes into points Ian Wienand
2024-05-27  0:30             ` [PATCH v7 2/3] Documentation: alias: add notes on shell expansion Ian Wienand
2024-05-27 17:48               ` Junio C Hamano
2024-05-27  0:30             ` [PATCH v7 3/3] run-command: show prepared command Ian Wienand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPig+cSDZzwH5RLYXbUXvdePHUtrPDDEdapQakB22zBkO25kuw@mail.gmail.com \
    --to=sunshine@sunshineco.com \
    --cc=git@vger.kernel.org \
    --cc=iwienand@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).