From: Eric Sunshine <sunshine@sunshineco.com>
To: "Sébastien Guimmara" <sebastien.guimmara@gmail.com>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v7 2/5] command-list.txt: add a [common] block
Date: Fri, 15 May 2015 17:31:45 -0400 [thread overview]
Message-ID: <CAPig+cSJJroxRF2He4ZvmgijZVw9ULOnUCEWyxGry=--L851YA@mail.gmail.com> (raw)
In-Reply-To: <1431714904-16599-3-git-send-email-sebastien.guimmara@gmail.com>
On Fri, May 15, 2015 at 2:35 PM, Sébastien Guimmara
<sebastien.guimmara@gmail.com> wrote:
> Add a [common] block at the beginning of command-list.txt:
Without benefit of the explanation in the cover letter, the reason for
this change is a bit mysterious. Even a single sentence preceding this
one could help clarify. Perhaps the above could be rewritten something
like this:
The ultimate goal is for "git help" to display common commands in
groups rather than alphabetically. As a first step, define the
groups in a new [common] block, and then assign a group to each
common command.
> [common]
> init start a working area (see also: git help tutorial)
> worktree work on the current change (see also:[...]
> info examine the history and state (see also: git [...]
> history grow, mark and tweak your history
> remote collaborate (see also: git help workflows)
>
> storing information about common commands group, then map each common
> command to a group:
>
> git-add mainporcelain common worktree
With the above rewritten explanation, the rest of the commit message
(the above examples) becomes pretty much unnecessary and merely
repeats what the patch itself already says.
> Helped-by: Eric Sunshine <sunshine@sunshineco.com>
> Helped-by: Junio C Hamano <gitster@pobox.com>
> Helped-by: Emma Jane Hogbin Westby <emma.westby@gmail.com>
> Signed-off-by: Sébastien Guimmara <sebastien.guimmara@gmail.com>
next prev parent reply other threads:[~2015-05-15 21:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 18:34 [PATCH v7 0/5] git help: group common commands by theme Sébastien Guimmara
2015-05-15 18:35 ` [PATCH v7 1/5] command-list.txt: prepare with [commands] header Sébastien Guimmara
2015-05-15 20:26 ` Junio C Hamano
2015-05-15 20:33 ` Sébastien Guimmara
2015-05-15 20:44 ` Junio C Hamano
2015-05-15 20:52 ` Eric Sunshine
2015-05-15 22:26 ` Junio C Hamano
2015-05-15 23:55 ` Eric Sunshine
2015-05-18 16:25 ` Sébastien Guimmara
2015-05-15 21:15 ` Eric Sunshine
2015-05-16 9:44 ` Philip Oakley
2015-05-16 9:44 ` Sébastien Guimmara
2015-05-15 18:35 ` [PATCH v7 2/5] command-list.txt: add a [common] block Sébastien Guimmara
2015-05-15 21:31 ` Eric Sunshine [this message]
2015-05-15 18:35 ` [PATCH v7 3/5] generate-cmdlist: parse common group commands Sébastien Guimmara
2015-05-15 21:34 ` Eric Sunshine
2015-05-15 18:35 ` [PATCH v7 4/5] command-list.txt: drop the common tag Sébastien Guimmara
2015-05-15 21:41 ` Eric Sunshine
2015-05-15 18:35 ` [PATCH v7 5/5] help.c: output the typical Git workflow Sébastien Guimmara
2015-05-15 21:45 ` Eric Sunshine
2015-05-15 20:41 ` [PATCH v7 0/5] git help: group common commands by theme Eric Sunshine
2015-05-15 20:48 ` Junio C Hamano
2015-05-15 20:50 ` Sébastien Guimmara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cSJJroxRF2He4ZvmgijZVw9ULOnUCEWyxGry=--L851YA@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sebastien.guimmara@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).