From: Eric Sunshine <sunshine@sunshineco.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: "Git List" <git@vger.kernel.org>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH v2 2/2] t7900: make macOS-specific test work on Windows
Date: Mon, 30 Nov 2020 22:03:29 -0500 [thread overview]
Message-ID: <CAPig+cSK4y2P2PUVnXyaB5T0y-RBJOsb-npwM_8Wnm7oqRQLGQ@mail.gmail.com> (raw)
In-Reply-To: <e4647058-3bb6-7aa4-c245-95e3f4b3bc66@gmail.com>
On Mon, Nov 30, 2020 at 8:12 AM Derrick Stolee <stolee@gmail.com> wrote:
> On 11/29/2020 11:42 PM, Eric Sunshine wrote:
> > + # ensure $HOME can be compared against hook arguments on all platforms
> > + pfx=$(cd "$HOME" && pwd) &&
> > + PLIST="$pfx/Library/LaunchAgents/org.git-scm.git.$frequency.plist" &&
>
> This pair of changes make sense to get around the $HOME issue
> that caused me to surrender the effort.
In case it's not clear to other readers not familiar with Git on
Windows (or who have not read t/README), the magic here is that `pwd`
is overridden in t/test-lib.sh for MINGW to always return a
Windows-style path.
next prev parent reply other threads:[~2020-12-01 3:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 4:42 [PATCH v2 0/2] make macOS `git maintenance` test work on Windows Eric Sunshine
2020-11-30 4:42 ` [PATCH v2 1/2] t7900: fix test failures when invoked individually via --run Eric Sunshine
2020-11-30 4:42 ` [PATCH v2 2/2] t7900: make macOS-specific test work on Windows Eric Sunshine
2020-11-30 13:12 ` Derrick Stolee
2020-12-01 3:03 ` Eric Sunshine [this message]
2020-11-30 9:20 ` [PATCH v2 0/2] make macOS `git maintenance` " Ævar Arnfjörð Bjarmason
2020-11-30 23:32 ` Junio C Hamano
2020-12-01 3:58 ` Eric Sunshine
2020-12-01 12:31 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cSK4y2P2PUVnXyaB5T0y-RBJOsb-npwM_8Wnm7oqRQLGQ@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).