From: Eric Sunshine <sunshine@sunshineco.com>
To: Elia Pinto <gitter.spiros@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] imap-send.c: implements the GIT_CURL_DEBUG environment variable
Date: Wed, 6 Apr 2016 01:53:35 -0400 [thread overview]
Message-ID: <CAPig+cSR6CQ6Q=TOaTgqwC0nOkB_khDLevWDPZsOwKbGrjptKQ@mail.gmail.com> (raw)
In-Reply-To: <CA+EOSBmL8oHo_wWUzyBq=4Z7fFoFj5Gnf7UveOyiNMS3yhH8Uw@mail.gmail.com>
On Tue, Apr 5, 2016 at 6:21 AM, Elia Pinto <gitter.spiros@gmail.com> wrote:
> 2016-04-01 22:25 GMT+02:00 Eric Sunshine <sunshine@sunshineco.com>:
>> In addition to review comments by others, why are the new curl_dump()
>> and curl_trace() functions duplicated in both patches rather than
>> factored out to a shared implementation?
>
> It's right. Do you think i can use some existing file or should I
> create a new object file ?
Peff or Junio would be more qualified to answer, but perhaps the
shared implementation could go in http.c?
next prev parent reply other threads:[~2016-04-06 5:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 10:44 [PATCH 1/2] imap-send.c: implements the GIT_CURL_DEBUG environment variable Elia Pinto
2016-04-01 10:44 ` [PATCH 2/2] http.c: " Elia Pinto
2016-04-01 15:03 ` Ramsay Jones
2016-04-04 12:41 ` Elia Pinto
2016-04-01 11:44 ` [PATCH 1/2] imap-send.c: " Torsten Bögershausen
2016-04-01 14:56 ` Ramsay Jones
2016-04-04 12:45 ` Elia Pinto
2016-04-01 15:35 ` Junio C Hamano
2016-04-04 16:08 ` Elia Pinto
2016-04-04 16:50 ` Junio C Hamano
2016-04-01 20:25 ` Eric Sunshine
2016-04-05 10:21 ` Elia Pinto
2016-04-06 5:53 ` Eric Sunshine [this message]
2016-04-06 6:16 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cSR6CQ6Q=TOaTgqwC0nOkB_khDLevWDPZsOwKbGrjptKQ@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitter.spiros@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).