From: Eric Sunshine <sunshine@sunshineco.com>
To: Jeremy Sequoia <jeremyhu@apple.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Git List <git@vger.kernel.org>, Jeff King <peff@peff.net>
Subject: Re: [PATCH (Apple Git) 01/13] .gitignore: Remove *.s as it matches *.S on case insensitive filesystem
Date: Thu, 31 Jan 2019 14:48:08 -0500 [thread overview]
Message-ID: <CAPig+cST93AUt+7LHsigeA2=AHvNwveCPEszP6-kvjpkRTNmQQ@mail.gmail.com> (raw)
In-Reply-To: <F67B3B30-64D8-4B0D-A4FD-7263415B0064@apple.com>
On Thu, Jan 31, 2019 at 1:17 PM Jeremy Sequoia <jeremyhu@apple.com> wrote:
> > On Jan 31, 2019, at 09:57, Junio C Hamano <gitster@pobox.com> wrote:
> > I still do not see what problem you need a "solution" for in the
> > first place---I saw a few comments asking it in the thread, but saw
> > no answer. ppc/sha1ppc.S is already tracked, so any modification
> > you make in the working tree can be added to the index with "git
> > add" and "git status" would report when you have modification to
> > that file in the working tree, without any such extra entry in
> > .gitignore, no?
>
> This would have implications for anyone doing something similar or
> to anyone intending to add new assembly files to the tree (since
> they wouldn’t show up in status or get added with add -A),
This nugget finally gives readers an idea of the sort of issue this
patch wants to "fix", which happens to be related to HFS+ being
case-insensitive. As noted upstream, though, files which are already
tracked, such as ppc/sha1ppc.S, are not subject to .gitignore, so
Dscho's proposed modification to .gitignore:
...
*.[aos]
!ppc/sha1ppc.S
...
doesn't actually help. Moreover, this .gitignore change doesn't at all
help the case you describe about new assembly files not being noticed
by "git status" or "git add -A" since any new files won't be named
"ppc/sha1ppc.S".
As Junio said upstream, .gitignore ignoring "*.s" files is the right
thing to do for this project and, as adding new .S files is so rare,
it seems unlikely that a patch changing .gitignore to accommodate the
above use-case for case-insensitive filesystems would make sense to
the project as a whole.
next prev parent reply other threads:[~2019-01-31 19:48 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 19:38 [PATCH (Apple Git) 00/13] Differences between git-2.20.1 and Apple Git-116 Jeremy Huddleston Sequoia
2019-01-29 19:38 ` [PATCH (Apple Git) 01/13] .gitignore: Remove *.s as it matches *.S on case insensitive filesystem Jeremy Huddleston Sequoia
2019-01-30 11:33 ` Eric Sunshine
2019-01-30 11:37 ` Jeremy Huddleston Sequoia
2019-01-30 12:29 ` Eric Sunshine
2019-01-30 12:32 ` Eric Sunshine
2019-01-30 12:42 ` Johannes Schindelin
2019-01-30 19:13 ` Jeremy Huddleston Sequoia
2019-01-31 17:57 ` Junio C Hamano
2019-01-31 18:17 ` Jeremy Sequoia
2019-01-31 19:48 ` Eric Sunshine [this message]
2019-01-30 16:47 ` Junio C Hamano
2019-01-29 19:38 ` [PATCH (Apple Git) 02/13] test-lib: Export PERL5LIB for testing git-svn Jeremy Huddleston Sequoia
2019-01-29 22:47 ` Junio C Hamano
2019-01-29 23:46 ` Jeremy Huddleston Sequoia
2019-01-29 23:59 ` SZEDER Gábor
2019-01-30 0:01 ` Jeremy Sequoia
2019-01-30 18:59 ` Junio C Hamano
2019-01-30 0:07 ` Carlo Arenas
2019-01-30 12:51 ` Johannes Schindelin
2019-01-30 18:45 ` Jeremy Sequoia
2019-01-29 19:38 ` [PATCH (Apple Git) 03/13] t0500: New regression test for git add of a path that contains a .git directory Jeremy Huddleston Sequoia
2019-01-30 11:47 ` Eric Sunshine
2019-01-30 13:12 ` Johannes Schindelin
2019-01-30 19:04 ` Jeremy Huddleston Sequoia
2019-01-29 19:38 ` [PATCH (Apple Git) 04/13] t4014: git --version can have SP in it Jeremy Huddleston Sequoia
2019-01-29 22:58 ` Junio C Hamano
2019-01-30 13:30 ` Johannes Schindelin
2019-01-29 19:38 ` [PATCH (Apple Git) 05/13] t5701: " Jeremy Huddleston Sequoia
2019-01-30 13:36 ` Johannes Schindelin
2019-01-30 19:35 ` Jeremy Huddleston Sequoia
2019-01-29 19:38 ` [PATCH (Apple Git) 06/13] Set Apple Git version during build Jeremy Huddleston Sequoia
2019-01-30 13:43 ` Johannes Schindelin
2019-01-30 19:45 ` Jeremy Huddleston Sequoia
2019-01-29 19:38 ` [PATCH (Apple Git) 07/13] HTML documentation is not provided with Apple's git. Make the error message more on point Jeremy Huddleston Sequoia
2019-01-29 23:01 ` Junio C Hamano
2019-01-30 13:45 ` Johannes Schindelin
2019-01-30 16:50 ` Junio C Hamano
2019-01-30 19:34 ` Johannes Schindelin
2019-01-29 19:38 ` [PATCH (Apple Git) 08/13] git mergetool/difftool doesn't list 'opendiff' as an available tool on 10.8 Jeremy Huddleston Sequoia
2019-01-30 19:07 ` Johannes Schindelin
2019-01-29 19:38 ` [PATCH (Apple Git) 09/13] Use symbolic links rather than hard links for files in libexec Jeremy Huddleston Sequoia
2019-01-30 9:50 ` brian m. carlson
2019-01-30 11:41 ` Jeremy Huddleston Sequoia
2019-01-30 19:15 ` Johannes Schindelin
2019-01-30 20:52 ` Jeremy Huddleston Sequoia
2019-01-29 19:38 ` [PATCH (Apple Git) 10/13] Support for Xcode.app co-exestince and relocation Jeremy Huddleston Sequoia
2019-01-30 19:26 ` Johannes Schindelin
2019-01-30 21:07 ` Jeremy Huddleston Sequoia
2019-01-29 19:38 ` [PATCH (Apple Git) 11/13] Fix problem found from running the test suite Jeremy Huddleston Sequoia
2019-01-29 23:12 ` Junio C Hamano
2019-01-29 23:30 ` Eric Wong
2019-01-29 19:38 ` [PATCH (Apple Git) 12/13] Enable support for Xcode.app-bundled gitconfig Jeremy Huddleston Sequoia
2019-01-29 23:10 ` Junio C Hamano
2019-01-29 23:51 ` Jeremy Huddleston Sequoia
2019-01-30 19:32 ` Johannes Schindelin
2019-01-30 21:09 ` Jeremy Huddleston Sequoia
2019-01-30 22:01 ` Jeremy Huddleston Sequoia
2019-01-31 0:01 ` Jonathan Nieder
2019-01-31 8:29 ` Jeremy Huddleston Sequoia
2019-01-31 18:06 ` Junio C Hamano
2019-01-30 9:44 ` brian m. carlson
2019-01-29 19:38 ` [PATCH (Apple Git) 13/13] Enable support for Xcode.app-bundled gitattributes Jeremy Huddleston Sequoia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cST93AUt+7LHsigeA2=AHvNwveCPEszP6-kvjpkRTNmQQ@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeremyhu@apple.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).