From: Eric Sunshine <sunshine@sunshineco.com>
To: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Cc: "Git List" <git@vger.kernel.org>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Philippe Blain" <levraiphilippeblain@gmail.com>
Subject: Re: [PATCH] Makefile: avoid breaking compilation database generation with DEPELOPER
Date: Wed, 22 Sep 2021 14:45:24 -0400 [thread overview]
Message-ID: <CAPig+cSTiM-NWLOnSeYEhW8j5POYZ034m-cbMGdROFHp3kWXxQ@mail.gmail.com> (raw)
In-Reply-To: <20210922183311.3766-1-carenas@gmail.com>
On Wed, Sep 22, 2021 at 2:33 PM Carlo Marcelo Arenas Belón
<carenas@gmail.com> wrote:
> Makefile: avoid breaking compilation database generation with DEPELOPER
s/DEPELOPER/DEVELOPER/
> 3821c38068 (Makefile: add support for generating JSON compilation
> database, 2020-09-03), adds a feature to be used with clang to generate
> a compilation database by copying most of what was done before with the
> header dependency, but by doing so includes on its availability check
> the CFLAGS which became specially problematic once DEVELOPER=1 implied
> -pedantic as pointed out by Ævar[1].
>
> Remove the unnecessary flags in the availability test, so it will work
> regardless of which other warnings are enabled or if the compilers has
s/compilers/compiler/
> been told to error on them.
>
> [1] https://lore.kernel.org/git/patch-1.1-6b2e9af5e67-20210922T103749Z-avarab@gmail.com/
>
> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
next prev parent reply other threads:[~2021-09-22 18:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 18:33 [PATCH] Makefile: avoid breaking compilation database generation with DEPELOPER Carlo Marcelo Arenas Belón
2021-09-22 18:45 ` Eric Sunshine [this message]
2021-09-22 18:57 ` [PATCH v2] Makefile: avoid breaking compilation database generation with DEVELOPER Carlo Marcelo Arenas Belón
2021-09-22 19:07 ` Philippe Blain
2021-09-23 1:41 ` brian m. carlson
2021-09-23 1:59 ` Carlo Arenas
2021-09-23 2:08 ` Ævar Arnfjörð Bjarmason
2021-09-23 0:55 ` [PATCH] Makefile: avoid breaking compilation database generation with DEPELOPER Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cSTiM-NWLOnSeYEhW8j5POYZ034m-cbMGdROFHp3kWXxQ@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=avarab@gmail.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=levraiphilippeblain@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).