From: Eric Sunshine <sunshine@sunshineco.com>
To: Usman Akinyemi <usmanakinyemi202@gmail.com>
Cc: git@vger.kernel.org, christian.couder@gmail.com,
gitster@pobox.com, johncai86@gmail.com, me@ttaylorr.com,
ps@pks.im, shejialuo@gmail.com, phillip.wood123@gmail.com,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH v2 1/1] builtin/update-server-info: remove unnecessary if statement
Date: Sun, 6 Apr 2025 20:24:18 -0400 [thread overview]
Message-ID: <CAPig+cShdouOzG_jKz_Z6+bSprZ5ZEsx9wZR-_LuD1P2kaOWwg@mail.gmail.com> (raw)
In-Reply-To: <20250406121513.154084-2-usmanakinyemi202@gmail.com>
On Sun, Apr 6, 2025 at 8:15 AM Usman Akinyemi
<usmanakinyemi202@gmail.com> wrote:
> Since we already teach the `repo_config()` in "1a764cdbdc
> (Merge branch 'ua/some-builtins-wo-the-repository', 2025-03-26)"
> to allow `repo` to be NULL, no need to check if `repo` is NULL
> before calling `repo_config()`.
Okay, makes sense. However...
By referencing only the merge commit in the above message, you force
reviewers and future readers to chase down and locate the actual
commit[*] which taught repo_config() to accept NULL for `repo`. To be
more friendly to those people, you should help them by instead
referencing the commit[*] itself.
[*]: f29f1990b5 (config: teach repo_config to allow `repo` to be NULL,
2025-03-08)
> Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>
next prev parent reply other threads:[~2025-04-07 0:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-29 11:59 [PATCH 0/1] remove unnecessary if statement Usman Akinyemi
2025-03-29 11:59 ` [PATCH 1/1] builtin/update-server-info: " Usman Akinyemi
2025-03-31 7:16 ` Patrick Steinhardt
2025-04-06 12:14 ` [PATCH v2 0/1] " Usman Akinyemi
2025-04-06 12:14 ` [PATCH v2 1/1] builtin/update-server-info: " Usman Akinyemi
2025-04-07 0:24 ` Eric Sunshine [this message]
2025-04-07 15:49 ` Junio C Hamano
2025-04-07 19:58 ` [PATCH v2 0/1] " Usman Akinyemi
2025-04-07 19:58 ` [PATCH 1/1] builtin/update-server-info: " Usman Akinyemi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cShdouOzG_jKz_Z6+bSprZ5ZEsx9wZR-_LuD1P2kaOWwg@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johncai86@gmail.com \
--cc=me@ttaylorr.com \
--cc=phillip.wood123@gmail.com \
--cc=ps@pks.im \
--cc=shejialuo@gmail.com \
--cc=usmanakinyemi202@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).