git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Taylor Blau <me@ttaylorr.com>,
	git@vger.kernel.org, Jeff King <peff@peff.net>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] builtin/repack.c: avoid making cruft packs preferred
Date: Thu, 5 Oct 2023 16:27:46 -0400	[thread overview]
Message-ID: <CAPig+cSp1MVVikAxtuq8XQPeoEtsaXETOywMTqM_CBDguASMUA@mail.gmail.com> (raw)
In-Reply-To: <ZR6ajQa8bh5HKsnr@tanuki>

On Thu, Oct 5, 2023 at 10:46 AM Patrick Steinhardt <ps@pks.im> wrote:
> On Tue, Oct 03, 2023 at 05:54:19PM -0400, Taylor Blau wrote:
> > +             /* The largest pack was repacked, meaning that either
> > +              * one or two packs exist depending on whether the
> > +              * repository has a cruft pack or not.
>
> Nit: this comment will grow stale soonish once your patch series lands
> that introduces a maximum packfile size for cruft packs as there can be
> arbitrarily many cruft packs from thereon.
>
> The rest of this patch series looks good to me and makes sense. I don't
> really think that this comment here is worth a reroll.

If you do happen to reroll for some reason, though, perhaps take care
of the minor style violation, as well. Use:

    /*
     * Multi-line comment
     * style.
     */

rather than:

    /* Multi-line comment
     * style.
     */

      reply	other threads:[~2023-10-05 20:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-03 16:27 [PATCH] builtin/repack.c: avoid making cruft packs preferred Taylor Blau
2023-10-03 16:30 ` Taylor Blau
2023-10-03 20:20   ` Junio C Hamano
2023-10-03 21:39     ` Taylor Blau
2023-10-03 20:16 ` Jeff King
2023-10-03 21:52   ` Taylor Blau
2023-10-03 21:54 ` [PATCH v2] " Taylor Blau
2023-10-04 13:13   ` Jeff King
2023-10-05 11:14   ` Patrick Steinhardt
2023-10-05 20:27     ` Eric Sunshine [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPig+cSp1MVVikAxtuq8XQPeoEtsaXETOywMTqM_CBDguASMUA@mail.gmail.com \
    --to=sunshine@sunshineco.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=me@ttaylorr.com \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).