From: Eric Sunshine <sunshine@sunshineco.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: "Git List" <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>,
"Manlio Perillo" <manlio.perillo@gmail.com>,
"Matthieu Moy" <Matthieu.Moy@imag.fr>,
"SZEDER Gábor" <szeder@ira.uka.de>
Subject: Re: [PATCH v2 9/9] completion: remove __git_index_file_list_filter()
Date: Sat, 27 Apr 2013 21:41:54 -0400 [thread overview]
Message-ID: <CAPig+cSp2wsvZaJ1vKn3UOGL4FyGFj4j4OFKQAeN-pVNMYZKaw@mail.gmail.com> (raw)
In-Reply-To: <1367093407-8898-10-git-send-email-felipe.contreras@gmail.com>
On Sat, Apr 27, 2013 at 4:10 PM, Felipe Contreras
<felipe.contreras@gmail.com> wrote:
> Refactor the code into the only caller; __git_index_files().
>
> Also, Somehow messing up with the 'path' variable messes up the 'PATH'
s/Somehow/somehow/
s/messing up/messing/
> variable. So let's not do that.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
next prev parent reply other threads:[~2013-04-28 1:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-27 20:09 [PATCH v2 0/9] completion: general cleanups Felipe Contreras
2013-04-27 20:09 ` [PATCH v2 1/9] completion: add file completion tests Felipe Contreras
2013-04-27 21:24 ` Junio C Hamano
2013-04-27 20:10 ` [PATCH v2 2/9] completion: document tilde expansion failure in tests Felipe Contreras
2013-04-27 20:10 ` [PATCH v2 3/9] completion; remove unuseful comments Felipe Contreras
2013-04-27 20:10 ` [PATCH v2 4/9] completion: use __gitcompadd for __gitcomp_file Felipe Contreras
2013-04-27 20:10 ` [PATCH v2 5/9] completion: refactor diff_index wrappers Felipe Contreras
2013-04-27 21:29 ` Junio C Hamano
2013-04-27 20:10 ` [PATCH v2 6/9] completion: refactor __git_complete_index_file() Felipe Contreras
2013-04-27 20:10 ` [PATCH v2 7/9] completion: add hack to enable file mode in bash < 4 Felipe Contreras
2013-04-27 20:10 ` [PATCH v2 8/9] completion: add space after completed filename Felipe Contreras
2013-04-27 20:10 ` [PATCH v2 9/9] completion: remove __git_index_file_list_filter() Felipe Contreras
2013-04-28 1:41 ` Eric Sunshine [this message]
2013-04-28 1:45 ` Felipe Contreras
2013-04-27 21:34 ` [PATCH v2 0/9] completion: general cleanups Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cSp2wsvZaJ1vKn3UOGL4FyGFj4j4OFKQAeN-pVNMYZKaw@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=Matthieu.Moy@imag.fr \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=manlio.perillo@gmail.com \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).