git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Brian Gernhardt <brian@gernhardtsoftware.com>,
	"git@vger.kernel.org List" <git@vger.kernel.org>
Subject: Re: t3010 broken by 2eac2a4
Date: Thu, 22 Aug 2013 19:15:27 -0400	[thread overview]
Message-ID: <CAPig+cSqtMOYvxbvXstm9nqQD9sQ378NKCHSK7Ec6GrK5VJiGA@mail.gmail.com> (raw)
In-Reply-To: <xmqqwqndpbfc.fsf@gitster.dls.corp.google.com>

On Thu, Aug 22, 2013 at 7:12 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Eric Sunshine <sunshine@sunshineco.com> writes:
>
>> Status update: For the 'pathx' directory created by the t3010 test,
>> directory_exists_in_index() returns false on OSX, but true is returned
>> on Linux.
>
> Because a regular pathx/ju is in the index at that point, the
> correct answer directory_exists_in_index() should give for 'pathx'
> is "index_directory", not "index_nonexistent", I think.

directory_exists_in_index() and directory_exists_in_index_icase() are
behaving differently. You can replicate the problem on Linux by
enabling core.ignorecase in the test (sans gmail whitespace damage):

-->8--
diff --git a/t/t3010-ls-files-killed-modified.sh b/t/t3010-ls-files-killed-modif
index 3120efd..8c76160 100755
--- a/t/t3010-ls-files-killed-modified.sh
+++ b/t/t3010-ls-files-killed-modified.sh
@@ -89,7 +89,7 @@ test_expect_success 'git ls-files -k to show killed files.' '
        : >path9 &&
        touch path10 &&
        >pathx/ju/nk &&
-       git ls-files -k >.output
+       git -c core.ignorecase=true ls-files -k >.output
 '
-->8--

  reply	other threads:[~2013-08-22 23:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-21 20:31 t3010 broken by 2eac2a4 Brian Gernhardt
2013-08-21 21:41 ` Junio C Hamano
2013-08-22 20:54   ` Eric Sunshine
2013-08-22 21:16     ` Junio C Hamano
2013-08-22 21:22       ` Eric Sunshine
2013-08-22 21:32         ` Junio C Hamano
2013-08-22 21:35           ` Eric Sunshine
2013-08-22 21:43             ` Junio C Hamano
2013-08-22 21:59               ` Eric Sunshine
2013-08-22 22:53                 ` Eric Sunshine
2013-08-22 23:12                   ` Junio C Hamano
2013-08-22 23:15                     ` Eric Sunshine [this message]
2013-08-23  4:32                       ` Eric Sunshine
2013-08-23  5:36                         ` Junio C Hamano
2013-08-23  9:19                           ` Eric Sunshine
2013-08-23 17:15                             ` Junio C Hamano
2013-08-23 18:51                               ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPig+cSqtMOYvxbvXstm9nqQD9sQ378NKCHSK7Ec6GrK5VJiGA@mail.gmail.com \
    --to=sunshine@sunshineco.com \
    --cc=brian@gernhardtsoftware.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).