From: Eric Sunshine <sunshine@sunshineco.com>
To: "Paul A. Kennedy" <pakenned@pobox.com>
Cc: Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: unexpected file deletion after using git rebase --abort
Date: Thu, 4 Jul 2013 19:27:36 -0400 [thread overview]
Message-ID: <CAPig+cSz2MH4REJyNDox_NCM3DnFamizzMMiDzX=SumpDL77Gw@mail.gmail.com> (raw)
In-Reply-To: <20130704193550.GA4183@localhost.localdomain>
On Thu, Jul 4, 2013 at 3:35 PM, Paul A. Kennedy <pakenned@pobox.com> wrote:
> diff --git a/Documentation/git-rebase.txt b/Documentation/git-rebase.txt
> index aca8405..ffaef29 100644
> --- a/Documentation/git-rebase.txt
> +++ b/Documentation/git-rebase.txt
> @@ -238,6 +238,13 @@ leave out at most one of A and B, in which case it defaults to HEAD.
> will be reset to where it was when the rebase operation was
> started.
>
> + Untracked files added to the index will not be unstaged, and
> + therefore, not present in the working directory upon abort.
> + Unstage files before the abort, or stash untracked content before
> + starting the rebase (see linkgit:git-stash[1]). Dangling blobs
> + may be found and recovered using fsck and cat-file (see
> + linkgit:git-fsck[1], linkgit:git-cat-file[1]).
> +
Not commenting about the change in general, just one issue: The
transition to "dangling blobs" seems abrupt and may convey little
meaning to non-expert users. Perhaps lead in to that sentence with
something along the lines of:
"If you neglect to unstage untracked files before abort, they become
dangling blogs, which may be found ..."
Also, a bit earlier, perhaps: s/Unstage files/Manually unstage files/
next prev parent reply other threads:[~2013-07-04 23:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-03 22:44 unexpected file deletion after using git rebase --abort Paul A. Kennedy
2013-07-03 22:56 ` Jonathan Nieder
2013-07-03 23:04 ` Junio C Hamano
2013-07-04 19:35 ` Paul A. Kennedy
2013-07-04 23:27 ` Eric Sunshine [this message]
2013-07-05 7:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cSz2MH4REJyNDox_NCM3DnFamizzMMiDzX=SumpDL77Gw@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=pakenned@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).