From: Eric Sunshine <sunshine@sunshineco.com>
To: Caleb White <cdwhite3@pm.me>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/4] Link worktrees with relative paths
Date: Sun, 6 Oct 2024 01:14:43 -0400 [thread overview]
Message-ID: <CAPig+cT6LALKjEappB7QkB7oc88NyMcr40T_qJGL2mPA77K7XQ@mail.gmail.com> (raw)
In-Reply-To: <zKUnWY8u1SJNeS4oLK85znjacgYJJeN8HefenwaJ9B9Q1YrQAumpAxWos4svaawkTfQZ_HaS3yp6WrOQQI7yt3ZO0UMCfkM0lJDDnMD-Lno=@pm.me>
On Sun, Oct 6, 2024 at 1:11 AM Caleb White <cdwhite3@pm.me> wrote:
> On Sunday, October 6th, 2024 at 00:04, Eric Sunshine <sunshine@sunshineco.com> wrote:
> > Unfortunately, these patches are whitespace-damaged. Can you please
> > resubmit using either `git send-email` or GitGitGadget[1]?
>
> I sent them with `git send-email`, let me try again and then if that
> doesn't work then I'll try GitGitGadget. Just out of curiosity, how
> could you tell that they are whitespaced-damaged (so I know what to
> look for)?
Hmm, that's very strange; git-send-email shouldn't be damaging them like that.
I noticed the whitespace-damage just by visual inspection as I quickly
scanned my eyes over the patches. For instance, in patch [1/4], I see:
+ struct strbuf backlink = STRBUF_INIT;
struct strbuf gitd
ir = STRBUF_INIT;
The "gitdir" variable got split.
next prev parent reply other threads:[~2024-10-06 5:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-06 4:59 [PATCH 0/4] Link worktrees with relative paths Caleb White
2024-10-06 4:59 ` [PATCH 1/4] worktree: refactor infer_backlink() to use *strbuf Caleb White
2024-10-06 4:59 ` [PATCH 2/4] worktree: link worktrees with relative paths Caleb White
2024-10-06 4:59 ` [PATCH 3/4] worktree: sync worktree paths after gitdir move Caleb White
2024-10-06 4:59 ` [PATCH 4/4] worktree: prevent null pointer dereference Caleb White
2024-10-06 5:04 ` [PATCH 0/4] Link worktrees with relative paths Eric Sunshine
2024-10-06 5:11 ` Caleb White
2024-10-06 5:14 ` Eric Sunshine [this message]
2024-10-06 5:16 ` Eric Sunshine
[not found] ` <TEfKiit-RYyr0ZuiQszaKaM64iSonfaQwWRqExOgXyPR1tVWyAzR3kVKmCd3aREZwDGuS5VXcHjCvneY-gCg2OuZyv2N2EkfARlZu4AVSsU=@pm.me>
[not found] ` <CAPig+cTE0gaD=7dwSqY4S+7AqRoU9yOrS4sdBoybj0Pfyk9vxA@mail.gmail.com>
2024-10-06 5:41 ` Caleb White
2024-10-06 5:50 ` Eric Sunshine
2024-10-06 6:05 ` Caleb White
2024-10-06 6:16 ` Eric Sunshine
2024-10-06 6:23 ` Caleb White
2024-10-06 7:45 ` Eric Sunshine
2024-10-06 9:00 ` Kristoffer Haugsbakk
2024-10-06 22:10 ` Caleb White
2024-10-06 22:08 ` Caleb White
2024-10-06 22:24 ` Eric Sunshine
2024-10-06 22:32 ` Caleb White
2024-10-06 5:11 ` Eric Sunshine
2024-10-06 22:01 ` Caleb White
2024-10-06 22:19 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cT6LALKjEappB7QkB7oc88NyMcr40T_qJGL2mPA77K7XQ@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=cdwhite3@pm.me \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).