From: Eric Sunshine <sunshine@sunshineco.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Stefan Beller <stefanbeller@googlemail.com>,
Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] create_delta_index: simplify condition always evaluating to true
Date: Fri, 16 Aug 2013 08:40:16 -0400 [thread overview]
Message-ID: <CAPig+cT7KcoVgxnDXUgYuxbpcTkUGqi8m56ArFbYxS5ubftxCw@mail.gmail.com> (raw)
In-Reply-To: <20130816114346.GC5123@vauxhall.crustytoothpaste.net>
On Fri, Aug 16, 2013 at 7:43 AM, brian m. carlson
<sandals@crustytoothpaste.net> wrote:
> On Thu, Aug 15, 2013 at 09:37:40PM +0200, Stefan Beller wrote:
>> When checking the previous lines in that function, we can deduct that
>> hsize must always be smaller than (1u<<31), since 506049c7df2c6
>> (fix >4GiB source delta assertion failure), because the entries is
>
> the entries are
'entries' is a variable name, thus singular. Stefan corrected it in v2
to say "because entries is capped..." (though it would have been even
a bit clearer to add quotes around 'entries').
>> capped at an upper bound of 0xfffffffeU, so hsize contains a maximum
>> value of 0x3fffffff, which is smaller than (1u<<31), so i will never
>> be larger than 31.
prev parent reply other threads:[~2013-08-16 12:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-15 19:37 [PATCH] create_delta_index: simplify condition always evaluating to true Stefan Beller
2013-08-15 21:21 ` Eric Sunshine
2013-08-15 21:34 ` Stefan Beller
2013-08-15 21:46 ` Eric Sunshine
2013-08-16 2:38 ` Nicolas Pitre
2013-08-16 16:47 ` Philip Oakley
2013-08-16 21:22 ` Stefan Beller
2013-08-17 6:58 ` Philip Oakley
2013-08-15 22:14 ` Philip Oakley
2013-08-15 21:43 ` Junio C Hamano
2013-08-15 22:04 ` Stefan Beller
2013-08-16 2:34 ` Nicolas Pitre
2013-08-16 11:43 ` brian m. carlson
2013-08-16 12:40 ` Eric Sunshine [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cT7KcoVgxnDXUgYuxbpcTkUGqi8m56ArFbYxS5ubftxCw@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sandals@crustytoothpaste.net \
--cc=stefanbeller@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).