git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: guriev-ns@ya.ru
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH] status: -i shorthand for --ignored command line option
Date: Wed, 8 Aug 2018 03:34:41 -0400	[thread overview]
Message-ID: <CAPig+cTD7XYbaPBzj36Eudrud80r-cz1CPLDsLA9CHJC6Yc-Qw@mail.gmail.com> (raw)
In-Reply-To: <20180808063926.11911-1-guriev-ns@ya.ru>

Thanks for the submission. A few comments below...

On Wed, Aug 8, 2018 at 2:48 AM Nicholas Guriev <guriev-ns@ya.ru> wrote:
> This short option saves the number of keys to press for the
> typically git-status command.
> ---

Your sign-off is missing. See Documentation/SubmittingPatches.

It's clear that a short name would be helpful to you, but you may need
to work harder to convince others that it makes sense to squat an a
short option name like 'i'. One argument you might use in the commit
message in support of adding a short name to --ignored is that the
related option --untracked-files already has a short name (-u).

>  builtin/commit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This patch neglects to update the documentation for git-status in
Documentation/git-status.txt. It will need to do so if this change is
ever to be accepted.

  reply	other threads:[~2018-08-08  7:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180804181539.29536-1-guriev-ns@ya.ru>
2018-08-08  6:39 ` [PATCH] status: -i shorthand for --ignored command line option Nicholas Guriev
2018-08-08  7:34   ` Eric Sunshine [this message]
2018-08-09  6:21     ` [PATCH v2] " Nicholas Guriev
2018-08-09 15:44       ` Junio C Hamano
2018-08-13  5:02         ` Коля Гурьев
2018-08-13 16:46           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPig+cTD7XYbaPBzj36Eudrud80r-cz1CPLDsLA9CHJC6Yc-Qw@mail.gmail.com \
    --to=sunshine@sunshineco.com \
    --cc=git@vger.kernel.org \
    --cc=guriev-ns@ya.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).