Re: [PATCH] disable grafts during fetch/push/bundle

[Eric Sunshine <sunshine@sunshineco.com>]

On Tue, Mar 4, 2014 at 8:05 PM, Jeff King <peff@peff.net> wrote:
> On Tue, Mar 04, 2014 at 08:00:44PM -0500, Eric Sunshine wrote:
>
>> >> > +int commit_grafts_loaded(void)
>> >> > +{
>> >> > +       return !!commit_graft_nr;
>> >> > +}
>> >>
>> >> Did you mean !!commit_graft ?
>> >
>> > Shouldn't they produce the same results?
>>
>> Yes they should, but the use of !! seemed to imply that you wanted to
>> apply it to the pointer value. (If you indeed intended to use
>> commit_graft_nr, then 'return commit_graft_nr', without !!, would have
>> been sufficient and idiomatic C.)
>
> I just wanted to normalize the return value to a boolean 0/1. Even when
> the input is an int, it eliminates surprises when you try to assign the
> result to a bitfield or other smaller-width type.

Thanks for the explanation.