From: Eric Sunshine <sunshine@sunshineco.com>
To: Marcio Almada <marcio.web2@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Git List" <git@vger.kernel.org>,
"SZEDER Gábor" <szeder@ira.uka.de>
Subject: Re: [PATCH] fix global bash variable leak on __gitcompappend
Date: Thu, 9 Apr 2015 15:26:50 -0400 [thread overview]
Message-ID: <CAPig+cTE+UbNaY3rewqCFjZW7nAYOTP167W3Bhp4AEZoVBt0tA@mail.gmail.com> (raw)
In-Reply-To: <CAOsHV+tCHrbmapXU+eei7v1jfiwdpK8jT+ue=kb_dm9nDXtq_Q@mail.gmail.com>
On Thu, Apr 9, 2015 at 9:52 AM, Marcio Almada <marcio.web2@gmail.com> wrote:
> 2015-04-09 0:56 GMT-03:00 Junio C Hamano <gitster@pobox.com>:
>> "Márcio Almada" <marcio.web2@gmail.com> writes:
>>> contrib/completion/git-completion.bash | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Nicely found and corrected. Please sign-off your patch and Cc area
>> experts if you can find them (I'll do that this time for you).
>
> Ok, I'll remember this next time. Thanks for your incredible work here.
Junio's implication was that you should reply to his message with:
Signed-off-by: Your Name <your@email>
Or re-send the patch with your sign-off added.
prev parent reply other threads:[~2015-04-09 19:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 5:45 [PATCH] fix global bash variable on __gitcompappend Márcio Almada
2015-04-08 5:45 ` [PATCH] fix global bash variable leak " Márcio Almada
2015-04-09 3:56 ` Junio C Hamano
2015-04-09 8:55 ` SZEDER Gábor
2015-04-09 13:52 ` Marcio Almada
2015-04-09 19:26 ` Eric Sunshine [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cTE+UbNaY3rewqCFjZW7nAYOTP167W3Bhp4AEZoVBt0tA@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=marcio.web2@gmail.com \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).