From: Eric Sunshine <sunshine@sunshineco.com>
To: Shawn Landden <shawn@churchofgit.com>
Cc: Git List <git@vger.kernel.org>, Shawn Landden <shawnlandden@gmail.com>
Subject: Re: [v3RFC] systemd socket activation support
Date: Fri, 3 Apr 2015 19:06:14 -0400 [thread overview]
Message-ID: <CAPig+cTFRz=b=hdsuP_v_1jzu9-utGEWQM_rkhpEBvq-chrZig@mail.gmail.com> (raw)
In-Reply-To: <1428100224-29441-1-git-send-email-shawn@churchofgit.com>
On Fri, Apr 3, 2015 at 6:30 PM, Shawn Landden <shawn@churchofgit.com> wrote:
> systemd supports git-daemon's existing --inetd mode as well.
>
> v2: actually test...
> v3: make optional, switch to libsystemd
Every issue raised by my review[1] of v2 still applies to v3, so I
won't bother repeating them here, however, there is one comment
(below) new to this version of the patch.
[1]: http://article.gmane.org/gmane.comp.version-control.git/266650
> shawn@zephyr:~/git/git$ ldd /lib/x86_64-linux-gnu/libsystemd.so.0
> linux-vdso.so.1 (0x00007ffeba7ec000)
> libcap.so.2 => /lib/x86_64-linux-gnu/libcap.so.2 (0x00007fea158fe000)
> libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fea155f9000)
> librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007fea153f0000)
> libselinux.so.1 => /lib/x86_64-linux-gnu/libselinux.so.1 (0x00007fea151cb000)
> liblzma.so.5 => /lib/x86_64-linux-gnu/liblzma.so.5 (0x00007fea14fa8000)
> libgcrypt.so.20 => /lib/x86_64-linux-gnu/libgcrypt.so.20 (0x00007fea14cc5000)
> libresolv.so.2 => /lib/x86_64-linux-gnu/libresolv.so.2 (0x00007fea14aae000)
> libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007fea148aa000)
> libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fea1468b000)
> libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fea142e7000)
> /lib64/ld-linux-x86-64.so.2 (0x00007fea15d5b000)
> libattr.so.1 => /lib/x86_64-linux-gnu/libattr.so.1 (0x00007fea140e2000)
> libpcre.so.3 => /lib/x86_64-linux-gnu/libpcre.so.3 (0x00007fea13e73000)
> libgpg-error.so.0 => /lib/x86_64-linux-gnu/libgpg-error.so.0 (0x00007fea13c61000)
>
> ewwwww...and only for two tiny functions.
>
> Signed-off-by: Shawn Landden <shawn@churchofgit.com>
> ---
> diff --git a/Makefile b/Makefile
> index 5f3987f..362af94 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1403,8 +1413,8 @@ ifdef NATIVE_CRLF
> endif
>
> ifdef USE_NED_ALLOCATOR
> - COMPAT_CFLAGS += -Icompat/nedmalloc
> - COMPAT_OBJS += compat/nedmalloc/nedmalloc.o
> + COMPAT_CFLAGS += -Icompat/nedmalloc
> + COMPAT_OBJS += compat/nedmalloc/nedmalloc.o
You're sneaking in (whitespace) changes unrelated to the rest of the
patch. Typically, such unrelated cleanups should be relegated to
separate preparatory patches. (In this case, however, the change is
probably unwarranted and likely accidental, but serves as a reminder
to review patches before sending them out.)
> endif
>
> ifdef GIT_TEST_CMP_USE_COPIED_CONTEXT
> diff --git a/daemon.c b/daemon.c
> index 9ee2187..16b9eda 100644
> --- a/daemon.c
> +++ b/daemon.c
prev parent reply other threads:[~2015-04-03 23:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 22:30 [v3RFC] systemd socket activation support Shawn Landden
2015-04-03 23:06 ` Eric Sunshine [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cTFRz=b=hdsuP_v_1jzu9-utGEWQM_rkhpEBvq-chrZig@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=shawn@churchofgit.com \
--cc=shawnlandden@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).