git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: Dima Tisnek <dimaqq@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Unitialised pointer free in is_crontab_available
Date: Thu, 17 Oct 2024 02:57:02 -0400	[thread overview]
Message-ID: <CAPig+cTNUNCftpr28F6USxVDm-2UZt+x9NxHJ+zbX3Daf5thBg@mail.gmail.com> (raw)
In-Reply-To: <CAGGBzXLN6eFZmgEE=KBp9vbcgYGGEbDJDUrfyVeYjuCrRiYcXA@mail.gmail.com>

On Thu, Oct 17, 2024 at 2:48 AM Dima Tisnek <dimaqq@gmail.com> wrote:
> This code will try to `free(cmd)` even if get_schedule_cmd returned 0,
> when it's safe to assume that &cmd was not allocated.
>
> If I read this right, as long as the special env var is not set, this
> function returns 0 and does not populate *out.
>
> Reproduce:
> run `git maintenance start` on a mac in some git repo

Does [1] resolve the problem for you?

[1]: https://lore.kernel.org/git/a5b1433abfd84cb627efc17f52e0d644ee207bb0.1728538282.git.ps@pks.im/

  reply	other threads:[~2024-10-17  6:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-17  6:48 Unitialised pointer free in is_crontab_available Dima Tisnek
2024-10-17  6:57 ` Eric Sunshine [this message]
2024-10-17  8:38   ` Kristoffer Haugsbakk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPig+cTNUNCftpr28F6USxVDm-2UZt+x9NxHJ+zbX3Daf5thBg@mail.gmail.com \
    --to=sunshine@sunshineco.com \
    --cc=dimaqq@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).