From: Eric Sunshine <sunshine@sunshineco.com>
To: "SZEDER Gábor" <szeder@ira.uka.de>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH v2 06/13] bash prompt: run 'git rev-parse --git-dir' directly instead of __gitdir()
Date: Tue, 18 Jun 2013 00:16:32 -0400 [thread overview]
Message-ID: <CAPig+cTXxxkburz1PySnYptN70QUM3JwkKq9g5ULRYpUai4MrQ@mail.gmail.com> (raw)
In-Reply-To: <1371521826-3225-7-git-send-email-szeder@ira.uka.de>
On Mon, Jun 17, 2013 at 10:16 PM, SZEDER Gábor <szeder@ira.uka.de> wrote:
> From: SZEDER Gábor <szeder@ira.uka.de>
>
> __git_ps1() finds out the path to the repository by using the
> __gitdir() helper function. __gitdir() is basically just a wrapper
> around 'git rev-parse --git-dir', extended with support for
> recognizing a remote repository given as argument, to use the path
> given on the command line, and with a few shortcuts to recognize a git
> repository in cwd or at $GIT_DIR quickly without actually running 'git
> rev-parse'. However, the former two is only necessary for the
> completion script but makes no sense for the bash prompt, while the
> latter shortcuts are performance optimizations __git_ps1() can do
> without (they just avoid the overhead of fork()+exec()ing a git
> process).
>
> Run 'git rev-parse --git-dir' directly in __git_ps1(), because it will
> allow this patch series to combine several $(git rev-parse ...)
> command substitutions in the main code path, and the overall
> performance benefit will far outweight the loss of those few shortcuts
s/outweight/outweigh/
> in __gitdir(). Furthermore, since __gitdir() is not needed anymore
> for the prompt, remove it from the prompt script finally eliminating
> its duplication between the prompt and completion scripts. Also
> remove the comment from the completion script warning about this code
> duplication.
>
> Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
next prev parent reply other threads:[~2013-06-18 4:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 2:16 [PATCH v2 00/13] bash prompt speedup SZEDER Gábor
2013-06-18 2:16 ` [PATCH v2 01/13] bash prompt: fix redirection coding style in tests SZEDER Gábor
2013-06-18 2:16 ` [PATCH v2 02/13] bash prompt: fix here document indentation in interactive rebase test SZEDER Gábor
2013-06-18 5:54 ` Jeff King
2013-06-18 2:16 ` [PATCH v2 03/13] completion, bash prompt: move __gitdir() tests to completion test suite SZEDER Gábor
2013-06-18 2:16 ` [PATCH v2 04/13] bash prompt: add a test for symbolic link symbolic refs SZEDER Gábor
2013-06-18 2:16 ` [PATCH v2 05/13] bash prompt: return early from __git_ps1() when not in a git repository SZEDER Gábor
2013-06-18 2:16 ` [PATCH v2 06/13] bash prompt: run 'git rev-parse --git-dir' directly instead of __gitdir() SZEDER Gábor
2013-06-18 4:16 ` Eric Sunshine [this message]
2013-06-18 2:17 ` [PATCH v2 07/13] bash prompt: use bash builtins to find out rebase state SZEDER Gábor
2013-06-18 2:17 ` [PATCH v2 08/13] bash prompt: use bash builtins to find out current branch SZEDER Gábor
2013-06-18 2:17 ` [PATCH v2 09/13] bash prompt: use bash builtins to get detached HEAD abbrev. object name SZEDER Gábor
2013-06-18 2:17 ` [PATCH v2 10/13] bash prompt: combine 'git rev-parse' executions SZEDER Gábor
2013-06-18 6:05 ` Jeff King
2013-06-18 9:49 ` SZEDER Gábor
2013-06-18 10:01 ` [PATCH] fixup! bash prompt: use bash builtins to find out current branch SZEDER Gábor
2013-06-18 2:17 ` [PATCH v2 11/13] bash prompt: use bash builtins to check stash state SZEDER Gábor
2013-06-18 2:17 ` [PATCH v2 12/13] bash prompt: avoid command substitution when checking for untracked files SZEDER Gábor
2013-06-18 2:17 ` [PATCH v2 13/13] bash prompt: avoid command substitution when finalizing gitstring SZEDER Gábor
2013-06-18 2:28 ` [PATCH v2 00/13] bash prompt speedup SZEDER Gábor
2013-06-18 16:48 ` Junio C Hamano
2013-06-18 19:35 ` Simon Oosthoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cTXxxkburz1PySnYptN70QUM3JwkKq9g5ULRYpUai4MrQ@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).