git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: Jeff King <peff@peff.net>
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"Torsten Bögershausen" <tboegi@web.de>,
	"Karthik Nayak" <karthik.188@gmail.com>,
	"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH v2] t6302: simplify non-gpg cases
Date: Mon, 9 May 2016 22:49:06 -0400	[thread overview]
Message-ID: <CAPig+cTa-7-cneOaFgtUnXPFbMZZA3b5m-3kJK2=qB5ASRmCqg@mail.gmail.com> (raw)
In-Reply-To: <20160510024032.GA16965@sigill.intra.peff.net>

On Mon, May 9, 2016 at 10:40 PM, Jeff King <peff@peff.net> wrote:
> On Mon, May 09, 2016 at 01:47:35PM -0400, Eric Sunshine wrote:
>> > -       test_prepare_expect <<-\EOF | sed -e "s/Z$//" >expect &&
>> > +       cat <<-\EOF | sed -e "s/Z$//" >expect &&
>>
>> To make this as close to a reversion as possible, this could be
>> restored to the original (sans 'cat'):
>>
>>     sed -e "s/Z$//" >expect <<-\EOF &&
>
> Thanks, I did the reversion with s/test_prepare_expect/cat/ rather than
> reverting 618310a, but I agree dropping this useless-use-of-cat is worth
> doing. Here's v2 with that change and your reviewed-by.

Looks good, thanks.

  reply	other threads:[~2016-05-10  2:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-07 16:15 t6392 broken on pu (Mac OS X) Torsten Bögershausen
2016-05-09 16:07 ` Jeff King
2016-05-09 16:30   ` Eric Sunshine
2016-05-09 16:49     ` [PATCH] t6302: simplify non-gpg cases Jeff King
2016-05-09 17:47       ` Eric Sunshine
     [not found]         ` <CAOLa=ZSZqs=++Hf8CF3pWEnJqmOA9ajuX03hzLMkuQ+ehXXCVQ@mail.gmail.com>
2016-05-09 21:37           ` Eric Sunshine
2016-05-10  2:40         ` [PATCH v2] " Jeff King
2016-05-10  2:49           ` Eric Sunshine [this message]
2016-05-10  6:03           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPig+cTa-7-cneOaFgtUnXPFbMZZA3b5m-3kJK2=qB5ASRmCqg@mail.gmail.com' \
    --to=sunshine@sunshineco.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=karthik.188@gmail.com \
    --cc=peff@peff.net \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).