git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: Nazri Ramliy <ayiehere@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	Git List <git@vger.kernel.org>, Jeff King <peff@peff.net>,
	Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH v3] Teach git to change to a given directory using -C option
Date: Wed, 4 Sep 2013 02:45:07 -0400	[thread overview]
Message-ID: <CAPig+cTmVfrRWNfoqUGbZnf=GhozSnBB+rm1uuKAZRiRYHr7Xg@mail.gmail.com> (raw)
In-Reply-To: <CAEY4ZpN4xgt+gJSVeTfDNC--xt3N+M7vVLFBC7FTWBQtjvN8tw@mail.gmail.com>

On Wed, Sep 4, 2013 at 2:36 AM, Nazri Ramliy <ayiehere@gmail.com> wrote:
> On Wed, Sep 4, 2013 at 6:46 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> I do not care too deeply either way, but I am curious if there was a
>> reason why you changed the earlier <directory> to <path>?  Somehow,
>> when we _know_ a path has to be a directory, I find it easier on the
>> readers to spell that out, instead of saying "this is a path",
>> implying that it could be a directory, a regular file, or even
>> non-existent.
>
> Eric made me do it :). Personally I prefer the non-ambiguous "directory"
> over "path". In fact, "directory" is used in the error message spat out
> by git:
>
>     $ git --work-tree
>     No directory given for --work-tree.
>     ...
>
>     $ git --git-dir
>     No directory given for --git-dir.
>     ...
>     $
>
> I think changing "<path>" to "<directory>" wherever appropriate in
> git.txt would be an improvement. Tangent: <dir> is shorter but that
> might not be easy on the translators.

Such a terminology change is orthogonal to the patch adding -C
support, so if you do pursue it, the terminology change should be a
separate patch (either preparatory or follow-up to the -C patch).

  reply	other threads:[~2013-09-04  6:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-03 11:59 [PATCH v3] Teach git to change to a given directory using -C option Nazri Ramliy
2013-09-03 22:46 ` Junio C Hamano
2013-09-03 23:37   ` Eric Sunshine
2013-09-04  6:36   ` Nazri Ramliy
2013-09-04  6:45     ` Eric Sunshine [this message]
2013-09-04 12:20     ` Nazri Ramliy
2013-09-08 10:32       ` Eric Sunshine
2013-09-09  1:49         ` Nazri Ramliy
2013-09-09  5:01           ` Eric Sunshine
2013-09-09 13:47             ` Nazri Ramliy
2013-09-09 16:32               ` Junio C Hamano
2013-09-09 17:42                 ` Eric Sunshine
2013-09-09 17:59                   ` Junio C Hamano
2013-09-09 18:43                 ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPig+cTmVfrRWNfoqUGbZnf=GhozSnBB+rm1uuKAZRiRYHr7Xg@mail.gmail.com' \
    --to=sunshine@sunshineco.com \
    --cc=ayiehere@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).