From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] ReviewingGuidelines: encourage positive reviews more
Date: Wed, 24 Jul 2024 17:39:43 -0400 [thread overview]
Message-ID: <CAPig+cTmWVXXXTay9TrAP4LkLB44eqTh-e2Wx5wo-k1wFR6dOg@mail.gmail.com> (raw)
In-Reply-To: <xmqqsevysdaa.fsf@gitster.g>
On Wed, Jul 24, 2024 at 5:14 PM Junio C Hamano <gitster@pobox.com> wrote:
> Let's add a few paragraphs to encourage positive reviews, which is a
> bit harder to give than a review to point out things to improve.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
> diff --git c/Documentation/ReviewingGuidelines.txt w/Documentation/ReviewingGuidelines.txt
> @@ -72,12 +72,29 @@ guidance, and concrete tips for interacting with patches on the mailing list.
> +- Do not hesitate to give positive reviews on a series from your
> + work coleague. If your positive review is written well, it will
s/coleague/colleague/
> + not make you look as if you two are representing corporate
> + interest on a series that is otherwise uninteresting to other
> + community members.
next prev parent reply other threads:[~2024-07-24 21:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-24 21:14 [PATCH] ReviewingGuidelines: encourage positive reviews more Junio C Hamano
2024-07-24 21:39 ` Eric Sunshine [this message]
2024-07-25 6:51 ` Patrick Steinhardt
2024-07-25 13:31 ` Derrick Stolee
2024-07-25 14:11 ` Patrick Steinhardt
2024-07-25 15:49 ` [PATCH v2] " Junio C Hamano
2024-07-26 12:22 ` Patrick Steinhardt
2024-07-26 20:20 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cTmWVXXXTay9TrAP4LkLB44eqTh-e2Wx5wo-k1wFR6dOg@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).