From: Eric Sunshine <sunshine@sunshineco.com>
To: Kevin Daudt <me@ikke.info>
Cc: "Git List" <git@vger.kernel.org>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: [RFC] column: show auto columns when pager is active
Date: Mon, 9 Oct 2017 19:27:19 -0400 [thread overview]
Message-ID: <CAPig+cTnm01CJJN6tf-K_6Ah7uDoMeMJAxHUbC9YE1TxvAKF5g@mail.gmail.com> (raw)
In-Reply-To: <20171009214543.12986-1-me@ikke.info>
On Mon, Oct 9, 2017 at 5:45 PM, Kevin Daudt <me@ikke.info> wrote:
> When columns are set to automatic for git tag and the output is
> paginated by git, the output is a single column instead of multiple
> columns.
>
> Standard behaviour in git is to honor auto values when the pager is
> active, which happens for example with commands like git log showing
> colors when being paged.
>
> Since ff1e72483 (tag: change default of `pager.tag` to "on",
> 2017-08-02), the pager has been enabled by default, exposing this
> problem to more people.
>
> finalize_colopts in column.c only checks whether the output is a TTY to
> determine if columns should be enabled with columns set to autol. Also check
Presumably: s/autol/auto/
> if the pager is active.
>
> Helped-by: Rafael Ascensão <rafa.almas@gmail.com>
> Signed-off-by: Kevin Daudt <me@ikke.info>
next prev parent reply other threads:[~2017-10-09 23:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 21:45 [RFC] column: show auto columns when pager is active Kevin Daudt
2017-10-09 23:27 ` Eric Sunshine [this message]
2017-10-10 10:30 ` Martin Ågren
2017-10-10 14:01 ` Jeff King
2017-10-10 17:02 ` Martin Ågren
2017-10-11 4:54 ` Kevin Daudt
2017-10-12 14:24 ` Jeff King
2017-10-10 14:10 ` Jeff King
2017-10-10 14:29 ` Jeff King
2017-10-10 17:04 ` Martin Ågren
2017-10-10 18:32 ` Kevin Daudt
2017-10-11 17:23 ` [PATCH] " Kevin Daudt
2017-10-11 18:12 ` Martin Ågren
2017-10-11 18:36 ` Kevin Daudt
2017-10-11 19:02 ` Martin Ågren
2017-10-16 18:35 ` [PATCH v2] " Kevin Daudt
2017-10-17 3:19 ` Junio C Hamano
2017-10-23 21:52 ` Jonathan Nieder
2017-10-24 1:11 ` Junio C Hamano
2017-10-24 1:18 ` Jonathan Nieder
2017-10-24 6:58 ` Kevin Daudt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cTnm01CJJN6tf-K_6Ah7uDoMeMJAxHUbC9YE1TxvAKF5g@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=me@ikke.info \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).